Skip Menu |
 

This queue is for tickets about the XML-XSH CPAN distribution.

Report information
The Basics
Id: 124748
Status: rejected
Worked: 15 min
Priority: 0/
Queue: XML-XSH

People
Owner: CHOROBA [...] cpan.org
Requestors: ETJ [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 1.8.5
Fixed in: (no value)



Subject: Perl 5.22+ - no defined(@array)
Download (untitled) / with headers
text/plain 299b
As seen in https://www.cpantesters.org/cpan/report/256581a6-df89-11e7-90de-9bb3705be811 and others, this line in https://metacpan.org/source/CHOROBA/XML-XSH-1.8.5/lib/XML/XSH/Completion.pm#L111 unless (defined @PATH_HASH) { is a fatal error on at least 5.22. Could you just remove the "defined"?
Download (untitled) / with headers
text/plain 117b
This distribution is deprecated. Use XML::XSH2 instead. I'll try to avoid automatic test runs in the future release.
Download (untitled) / with headers
text/plain 662b
On Fri Mar 09 18:42:18 2018, CHOROBA wrote: Show quoted text
> This distribution is deprecated. Use XML::XSH2 instead. I'll try to > avoid automatic test runs in the future release.
I did see the deprecation notice. I noticed the issue because Inline::XSH is installed on a Perl 5.22 and it's generating test failures for PDL there. Basically I think that just skipping all the tests (as I notice you are doing) because it's deprecated isn't doing anyone any favours; it's generating completely spurious fails for others. Therefore, I think the least harm would be done by de-skipping the tests so that the distro doesn't get installed anymore and then create pain for others.
Download (untitled) / with headers
text/plain 140b
Sorry: "doesn't get installed anymore" = "doesn't get installed anymore where the tests fail because something breaks the distro completely"


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.