Skip Menu |
 

This queue is for tickets about the Net-STOMP-Client CPAN distribution.

Report information
The Basics
Id: 124655
Status: new
Priority: 0/
Queue: Net-STOMP-Client

People
Owner: Nobody in particular
Requestors: MHC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments
scalar_timeout_also_applies_to_disconnect.patch



Subject: [Doc Patch] Scalar timeout also applies to disconnect
Download (untitled) / with headers
text/plain 817b
According to the docs for timeouts: As a shortcut, the timeout attribute can also be a scalar. In this case, only the connect and connected operations use this value. However, the value is also applied to disconnect: sub _check_timeout ($) { my($self) = @_; my($timeout); $timeout = $self->{"timeout"}; if (defined($timeout)) { if (ref($timeout) eq "") { # scalar timeout specified -> backward compatibility $timeout = { "connect" => $timeout, "connected" => $timeout, "disconnect" => $timeout, "send" => undef, "receive" => undef, }; The attached patch updates the documentation to match the code.
Subject: scalar_timeout_also_applies_to_disconnect.patch
--- lib/Net/STOMP/Client.pm 2018-03-02 15:20:50.000000000 -0600 +++ lib/Net/STOMP/Client.pm.new 2018-03-02 15:20:44.000000000 -0600 @@ -1118,7 +1118,7 @@ succeeds. As a shortcut, the C<timeout> attribute can also be a scalar. In this case, -only the C<connect> and C<connected> operations use this value. +only the C<connect>, C<connected>, and C<disconnect> operations use this value. =head1 STOMP METHODS


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.