Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the HTTP-Message CPAN distribution.

Report information
The Basics
Id:
124526
Status:
resolved
Priority:
Low/Low
Queue:

People
Owner:
Nobody in particular
Requestors:
bitcardbmw [...] lsmod.de
Cc:
AdminCc:

BugTracker
Severity:
Normal
Broken in:
6.14
Fixed in:
(no value)



Subject: timegm should be called with 4-digit year
man Time::Local says Whenever possible, use an absolute four digit year instead. With a detailed explanation about ambiguity of 2-digit years above that. Please review/test/merge the attached patch --- HTTP-Message-6.14.orig/t/message-old.t +++ HTTP-Message-6.14/t/message-old.t @@ -16 +16 @@ require Time::Local if $^O eq "MacOS"; -my $offset = ($^O eq "MacOS") ? Time::Local::timegm(0,0,0,1,0,70) : 0; +my $offset = ($^O eq "MacOS") ? Time::Local::timegm(0,0,0,1,0,1970) : 0;
On Thu Feb 22 00:58:43 2018, bmwiedemann wrote:
Show quoted text
> man Time::Local says > > Whenever possible, use an absolute four digit year instead. > > With a detailed explanation about ambiguity of 2-digit years above that. > > Please review/test/merge the attached patch > > --- HTTP-Message-6.14.orig/t/message-old.t > +++ HTTP-Message-6.14/t/message-old.t > @@ -16 +16 @@ require Time::Local if $^O eq "MacOS"; > -my $offset = ($^O eq "MacOS") ? Time::Local::timegm(0,0,0,1,0,70) : 0; > +my $offset = ($^O eq "MacOS") ? Time::Local::timegm(0,0,0,1,0,1970) : 0;
Thanks! Patch will be applied via https://rt.cpan.org/Public/Bug/Display.html?id=124526
On Thu Feb 22 11:50:17 2018, OALDERS wrote:
Show quoted text
> On Thu Feb 22 00:58:43 2018, bmwiedemann wrote:
> > man Time::Local says > > > > Whenever possible, use an absolute four digit year instead. > > > > With a detailed explanation about ambiguity of 2-digit years above > > that. > > > > Please review/test/merge the attached patch > > > > --- HTTP-Message-6.14.orig/t/message-old.t > > +++ HTTP-Message-6.14/t/message-old.t > > @@ -16 +16 @@ require Time::Local if $^O eq "MacOS"; > > -my $offset = ($^O eq "MacOS") ? Time::Local::timegm(0,0,0,1,0,70) : > > 0; > > +my $offset = ($^O eq "MacOS") ? Time::Local::timegm(0,0,0,1,0,1970) > > : 0;
> > Thanks! Patch will be applied via > https://rt.cpan.org/Public/Bug/Display.html?id=124526
That should have been https://github.com/libwww-perl/HTTP-Message/pull/97


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.