Skip Menu |
 

This queue is for tickets about the Net-OpenSSH CPAN distribution.

Report information
The Basics
Id: 124357
Status: resolved
Priority: 0/
Queue: Net-OpenSSH

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 0.74
Fixed in: (no value)



Subject: Allow files_from and from0?
Download (untitled) / with headers
text/plain 1.4k
Is there a reason that the rsync* options files_from and from0 are explicitly forbidden? I tried this change: diff --git i/lib/Net/OpenSSH.pm w/lib/Net/OpenSSH.pm index 775bafd..41a17a3 100644 --- i/lib/Net/OpenSSH.pm +++ w/lib/Net/OpenSSH.pm @@ -2285,11 +2285,11 @@ sub _scp { my %rsync_opt_with_arg = map { $_ => 1 } qw(chmod suffix backup-dir rsync-path max-delete max-size min-size partial-dir timeout modify-window temp-dir compare-dest copy-dest link-dest compress-level skip-compress filter exclude exclude-from include include-from - out-format log-file log-file-format bwlimit protocol iconv checksum-seed); + out-format log-file log-file-format bwlimit protocol iconv checksum-seed files-from); my %rsync_opt_forbidden = map { $_ => 1 } qw(rsh address port sockopts blocking-io password-file write-batch only-write-batch read-batch ipv4 ipv6 version help daemon config detach - files-from from0 blocking-io protect-args list-only); + blocking-io protect-args list-only); $rsync_opt_forbidden{"no-$_"} = 1 for (keys %rsync_opt_with_arg, keys %rsync_opt_forbidden); ... and using files_from & from0 in rsync_put seems to work.
Download (untitled) / with headers
text/plain 121b
Probably I was just being over defensive. Patch applied, Thank you! https://metacpan.org/release/SALVA/Net-OpenSSH-0.76


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.