Skip Menu |
 

This queue is for tickets about the Catalyst-Runtime CPAN distribution.

Report information
The Basics
Id: 124036
Status: resolved
Priority: 0/
Queue: Catalyst-Runtime

People
Owner: Nobody in particular
Requestors: RANDIR [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Tests broken on blead
Download (untitled) / with headers
text/plain 4.2k
Catalyst fails t/aggregate/live_engine_request_uploads.t on recent bleadperl with the following output: 1..105 ok 1 - Request ok 2 - Response Successful 2xx ok 3 - Response Content-Type ok 4 - Content is a serialized Catalyst::Request ok 5 - Unserialize Catalyst::Request ok 6 - An object of class 'Catalyst::Request' isa 'Catalyst::Request' ok 7 - Catalyst::Request method ok 8 - Catalyst::Request Content-Type ok 9 - Catalyst::Request Content-Length ok 10 - An object of class 'Catalyst::Request::Upload' isa 'Catalyst::Request::Upload' ok 11 - Upload Content-Type ok 12 - Upload Content-Length ok 13 - legacy param method ok ok 14 - Upload temp file was deleted ok 15 - An object of class 'Catalyst::Request::Upload' isa 'Catalyst::Request::Upload' ok 16 - Upload Content-Type ok 17 - Upload Content-Length ok 18 - legacy param method ok ok 19 - Upload temp file was deleted ok 20 - An object of class 'Catalyst::Request::Upload' isa 'Catalyst::Request::Upload' ok 21 - Upload Content-Type ok 22 - Upload Content-Length ok 23 - legacy param method ok ok 24 - Upload temp file was deleted ok 25 - Request ok 26 - Response Successful 2xx ok 27 - Response Content-Type ok 28 - Content is a serialized Catalyst::Request ok 29 - Unserialize Catalyst::Request ok 30 - An object of class 'Catalyst::Request' isa 'Catalyst::Request' ok 31 - Catalyst::Request method ok 32 - Catalyst::Request Content-Type ok 33 - Catalyst::Request Content-Length ok 34 - An object of class 'Catalyst::Request::Upload' isa 'Catalyst::Request::Upload' ok 35 - Upload Content-Type ok 36 - Upload filename ok 37 - Upload Content-Length ok 38 - Upload basename ok 39 - Upload temp file was deleted ok 40 - An object of class 'Catalyst::Request::Upload' isa 'Catalyst::Request::Upload' ok 41 - Upload Content-Type ok 42 - Upload filename ok 43 - Upload Content-Length ok 44 - Upload basename ok 45 - Upload temp file was deleted ok 46 - An object of class 'Catalyst::Request::Upload' isa 'Catalyst::Request::Upload' ok 47 - Upload Content-Type ok 48 - Upload filename ok 49 - Upload Content-Length ok 50 - Upload basename ok 51 - Upload temp file was deleted ok 52 - Request ok 53 - Response Successful 2xx ok 54 - Response Content-Type ok 55 - Content ok 56 - Request ok 57 - Response Error ok 58 - Request ok 59 - Response Successful 2xx ok 60 - Response Content-Type ok 61 - Upload with name file1 ok 62 - Upload with name file2 ok 63 - Unserialize Catalyst::Request ok 64 - Upload temp file was deleted ok 65 - Upload temp file was deleted ok 66 - Request ok 67 - Response Successful 2xx ok 68 - Response Content-Type ok 69 - Content is a serialized Catalyst::Request ok 70 - Unserialize Catalyst::Request ok 71 - An object of class 'Catalyst::Request' isa 'Catalyst::Request' ok 72 - Catalyst::Request method ok 73 - Catalyst::Request Content-Type ok 74 - Catalyst::Request Content-Length ok 75 - 2 values ok 76 - correct value ok 77 - filename ok 78 - An object of class 'Catalyst::Request::Upload' isa 'Catalyst::Request::Upload' ok 79 - Upload Content-Type ok 80 - Upload Content-Length ok 81 - Upload Filename ok 82 - Upload basename ok 83 - Upload temp file was deleted ok 84 - Request ok 85 - Response Successful 2xx ok 86 - Response Content-Type ok 87 - Content is a serialized HTTP::Body::OctetStream not ok 88 - Unserialize HTTP::Body::OctetStream # Failed test 'Unserialize HTTP::Body::OctetStream' # at t/aggregate/live_engine_request_uploads.t line 322. Unmatched right curly bracket at (eval 704) line 17, at end of line syntax error at (eval 704) line 17, near "; }" Unmatched right curly bracket at (eval 704) line 18, at end of line not ok 89 - undef isa 'HTTP::Body::OctetStream' # Failed test 'undef isa 'HTTP::Body::OctetStream'' # at t/aggregate/live_engine_request_uploads.t line 329. # undef isn't defined Can't call method "body" on an undefined value at t/aggregate/live_engine_request_uploads.t line 331. # Looks like your test exited with 25 just after 89. Bisect points to commit abda9fe0fe75ae824723761c1c98af958f17a41c Author: Zefram <zefram@fysh.org> Date: Fri Dec 1 17:35:35 2017 +0000 in Data-Dumper, quote glob names better Glob name quoting should obey Useqq. Fixes [perl #119831]. which is quite strange commit for such cause. Corresponding core ticket is https://rt.perl.org/Public/Bug/Display.html?id=132695.
Download (untitled) / with headers
text/plain 1.6k
$response->content for this test is: $VAR1 = bless( { 'body' => bless( \*{'File::Temp::$fh'}, 'File::Temp' ), 'upload' => {}, 'length' => 9, 'chunk_buffer' => '', 'content_length' => 9, 'state' => 'done', 'tmpdir' => '/var/folders/4f/y458q_3n2g75w6m_k19nn8kr0000gp/T', 'cleanup' => 1, 'part_data' => {}, 'param_order' => [], 'content_type' => 'application/octet-stream', 'chunked' => '', 'param' => {}, 'buffer' => '' }, 'HTTP::Body::OctetStream' ); } = \'/var/folders/4f/y458q_3n2g75w6m_k19nn8kr0000gp/T/S9gFNebjf2'; } = { 'UNLINK' => 1, 'DIR' => '/var/folders/4f/y458q_3n2g75w6m_k19nn8kr0000gp/T' }; In 5.27.6 and earlier perls, it is: $VAR1 = bless( { 'state' => 'done', 'param_order' => [], 'cleanup' => 1, 'content_length' => 9, 'chunked' => '', 'buffer' => '', 'content_type' => 'application/octet-stream', 'body' => bless( \*{'File::Temp::$fh'}, 'File::Temp' ), 'length' => 9, 'param' => {}, 'chunk_buffer' => '', 'tmpdir' => '/var/folders/4f/y458q_3n2g75w6m_k19nn8kr0000gp/T', 'upload' => {}, 'part_data' => {} }, 'HTTP::Body::OctetStream' ); *{'File::Temp::$fh'} = \'/var/folders/4f/y458q_3n2g75w6m_k19nn8kr0000gp/T/0GxQvKlK9b'; *{'File::Temp::$fh'} = { 'UNLINK' => 1, 'DIR' => '/var/folders/4f/y458q_3n2g75w6m_k19nn8kr0000gp/T' }; Conclusion: the Data::Dumper output is no longer eval'able (leaving aside the inherent security risks), therefore this would appear to be an issue with the blead commit.
Fixed in blead


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.