Skip Menu |
 

This queue is for tickets about the Net-SSLeay CPAN distribution.

Report information
The Basics
Id: 123775
Status: resolved
Priority: 0/
Queue: Net-SSLeay

People
Owner: MIKEM [...] cpan.org
Requestors: hvn [...] open.com.au
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 1.83



Subject: Patch: Add support for SSL_set_default_passwd_cb
Date: Tue, 28 Nov 2017 16:31:33 +0200
To: bug-Net-SSLeay [...] rt.cpan.org
From: Heikki Vatiainen <hvn [...] open.com.au>
Download (untitled) / with headers
text/plain 925b
OpenSSL 1.1.0 added SSL_set_default_passwd_cb and SSL_set_default_passwd_cb_userdata functions. However, these are not called for SSL object before version 1.1.0f. The change in 1.1.0f may cause some programs to hang while they wait input to unlock the secret key. The reason is that the callback set for a CTX is no longer called for a SSL object. The attached patch adds support for SSL_set_default_passwd_cb* for OpenSSL 1.1.0f and later. LibreSSL does not support these functions, at least yet. The patch also adds new tests for the new functions and updates some of the current tests for CTX_set_default_passwd_cb* functions. The updated test may be useful as an example of detecting the availability of SSL_set_default_passwd_cb. Here are some links with more information: https://github.com/openssl/openssl/pull/2870 https://github.com/openssl/openssl/issues/3594 -- Heikki Vatiainen <hvn@open.com.au>

Message body is not shown because sender requested not to inline it.

Subject: Re: [rt.cpan.org #123775] Patch: Add support for SSL_set_default_passwd_cb
Date: Wed, 29 Nov 2017 16:57:05 +1100
To: bug-Net-SSLeay [...] rt.cpan.org
From: Mike McCauley <mikem [...] airspayce.com>
Download (untitled) / with headers
text/plain 1.5k
Thanks Heikki. Travelling this week but I will look at your patch next week. Cheers Sent from my iPhone Show quoted text
> On 29 Nov 2017, at 1:41 am, Heikki Vatiainen via RT <bug-Net-SSLeay@rt.cpan.org> wrote: > > Tue Nov 28 09:41:50 2017: Request 123775 was acted upon. > Transaction: Ticket created by hvn@open.com.au > Queue: Net-SSLeay > Subject: Patch: Add support for SSL_set_default_passwd_cb > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: hvn@open.com.au > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=123775 > > > > OpenSSL 1.1.0 added SSL_set_default_passwd_cb and > SSL_set_default_passwd_cb_userdata functions. However, these are not > called for SSL object before version 1.1.0f. > > The change in 1.1.0f may cause some programs to hang while they wait > input to unlock the secret key. The reason is that the callback set for > a CTX is no longer called for a SSL object. > > The attached patch adds support for SSL_set_default_passwd_cb* for > OpenSSL 1.1.0f and later. LibreSSL does not support these functions, at > least yet. > > The patch also adds new tests for the new functions and updates some of > the current tests for CTX_set_default_passwd_cb* functions. > > The updated test may be useful as an example of detecting the > availability of SSL_set_default_passwd_cb. > > Here are some links with more information: > > https://github.com/openssl/openssl/pull/2870 > https://github.com/openssl/openssl/issues/3594 > > -- > Heikki Vatiainen <hvn@open.com.au> > > <set_default_passwd_cb.patch>
Subject: Re: [rt.cpan.org #123775] Patch: Add support for SSL_set_default_passwd_cb
Date: Thu, 30 Nov 2017 16:39:38 +0200
To: bug-Net-SSLeay [...] rt.cpan.org
From: Heikki Vatiainen <hvn [...] open.com.au>
Download (untitled) / with headers
text/plain 316b
On 29.11.2017 8.45, Mike McCauley via RT wrote: Show quoted text
> Travelling this week but I will look at your patch next week.
Please find attached updated patch. I added compatibility notes to the .pod file but otherwise the contents are the same as in the first patch. Thanks, Heikki -- Heikki Vatiainen <hvn@open.com.au>

Message body is not shown because sender requested not to inline it.

Subject: Re: [rt.cpan.org #123775] Patch: Add support for SSL_set_default_passwd_cb
Date: Sat, 02 Dec 2017 17:22:34 +1000
To: bug-Net-SSLeay [...] rt.cpan.org
From: Mike McCauley <mikem [...] airspayce.com>
Download (untitled) / with headers
text/plain 711b
Thanks Heikki, this patch is now in SVN 506. cheers. On Friday, 1 December 2017 12:40:08 AM AEST Heikki Vatiainen via RT wrote: Show quoted text
> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=123775 > > > On 29.11.2017 8.45, Mike McCauley via RT wrote:
> > Travelling this week but I will look at your patch next week.
> > Please find attached updated patch. I added compatibility notes to the > .pod file but otherwise the contents are the same as in the first patch. > > Thanks, > Heikki
-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.