Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the DBD-Oracle CPAN distribution.

Report information
The Basics
Id: 12304
Status: resolved
Priority: 0/
Queue: DBD-Oracle

People
Owner: Nobody in particular
Requestors: martin.ferrari [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.14
Fixed in: (no value)



Subject: DBD-Oracle-1.14: dbd_edit_mm_attribs should not be called
Download (untitled) / with headers
text/plain 1.1k
Sorry to file a bug against a old version, but since 1.15 and up require DBD 0.28, I cannot use them under Debian Woody... May be this serves for someone in my situation. After much head-banging, I saw that dbd_edit_mm_attribs was wiping the parameters passed later to WriteMakefile and so everything failed (it didn't even receive NAME). Lurking in the DBI::DBD code, I found what it seems to be a bug, as this ruins \%opts (as is a hash ref and not a hash): sub dbd_edit_mm_attribs { my %a = @_; return %a; } The solution was to remove that call, as anyways it was a NOOP. --- DBD-Oracle-1.14/Makefile.PL Thu Mar 27 13:44:36 2003 +++ DBD-Oracle-1.14-new/Makefile.PL Fri Apr 15 16:51:47 2005 @@ -96,7 +96,7 @@ if ($::opt_W) { open(MK_PM, ">/dev/null") or die "Unable to create mk.pm: $!"; - exit WriteMakefile( dbd_edit_mm_attribs(\%opts) ) + exit WriteMakefile( \%opts ) } # --- Introduction @@ -693,7 +693,7 @@ open(MK_PM, ">mk.pm") or die "Unable to create mk.pm: $!"; print "\n"; -WriteMakefile( dbd_edit_mm_attribs(\%opts) ); +WriteMakefile( \%opts ); check_security() unless $os eq 'VMS' or $os eq 'MSWin32' or $os =~ /cygwin/i;
From: martin.ferrari [...] gmail.com
Download (untitled) / with headers
text/plain 823b
[guest - Fri Apr 15 16:01:44 2005]: Show quoted text
> Lurking in the DBI::DBD code, I found what it seems to be a bug, as > this ruins \%opts (as is a hash ref and not a hash):
Wrong, passing a hashref was the mistake. There is the patch, again: --- DBD-Oracle-1.14/Makefile.PL Thu Mar 27 13:44:36 2003 +++ DBD-Oracle-1.14-new/Makefile.PL Fri Apr 15 17:33:16 2005 @@ -96,7 +96,7 @@ if ($::opt_W) { open(MK_PM, ">/dev/null") or die "Unable to create mk.pm: $!"; - exit WriteMakefile( dbd_edit_mm_attribs(\%opts) ) + exit WriteMakefile( %opts ) } # --- Introduction @@ -693,7 +693,7 @@ open(MK_PM, ">mk.pm") or die "Unable to create mk.pm: $!"; print "\n"; -WriteMakefile( dbd_edit_mm_attribs(\%opts) ); +WriteMakefile( %opts ); check_security() unless $os eq 'VMS' or $os eq 'MSWin32' or $os =~ /cygwin/i;
Download (untitled) / with headers
text/plain 111b
I don't understand the problem. I presume you're using old versions. There's no problem with current versions.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.