Skip Menu |
 

This queue is for tickets about the Mail-OpenDKIM CPAN distribution.

Report information
The Basics
Id: 122811
Status: resolved
Priority: 0/
Queue: Mail-OpenDKIM

People
Owner: INFRACANI [...] cpan.org
Requestors: Pascal [...] rkfd.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 4203
Fixed in: (no value)



Subject: KeyFile argument does not work
Download (untitled) / with headers
text/plain 602b
The documentation shows passing the name of the file containing the private key as an argument named KeyFile. Doing so results in the error: Can't call method "data" on an undefined value at /usr/local/lib64/perl5/Mail/OpenDKIM/Signer.pm line 131 It appears Signer.pm is expecting a Mail::OpenDKIM::PrivateKey to be passed as an argument named Key. I inserted the below in Signer.pm before line 128 to allow both the current and documented functionality. croak 'Private key not found' unless $args{Key} || ($args{KeyFile} && ($args{Key} = Mail::OpenDKIM::PrivateKey->load(File => $args{KeyFile})));
Download (untitled) / with headers
text/plain 803b
On Tue Aug 15 23:27:11 2017, Pascal@rkfd.com wrote: Show quoted text
> The documentation shows passing the name of the file containing the > private key as an argument named KeyFile. Doing so results in the > error: Can't call method "data" on an undefined value at > /usr/local/lib64/perl5/Mail/OpenDKIM/Signer.pm line 131 > > It appears Signer.pm is expecting a Mail::OpenDKIM::PrivateKey to be > passed as an argument named Key. I inserted the below in Signer.pm > before line 128 to allow both the current and documented > functionality. > > croak 'Private key not found' unless $args{Key} || ($args{KeyFile} && > ($args{Key} = Mail::OpenDKIM::PrivateKey->load(File => > $args{KeyFile})));
Thank you for your report. Yes, looks like your analysis is correct. I'll apply patches along the lines you suggest.
Download (untitled) / with headers
text/plain 402b
On Wed Aug 16 02:04:31 2017, INFRACANI wrote: Show quoted text
> > croak 'Private key not found' unless $args{Key} || ($args{KeyFile} && > > ($args{Key} = Mail::OpenDKIM::PrivateKey->load(File => > > $args{KeyFile})));
> > Thank you for your report. Yes, looks like your analysis is correct. I'll > apply patches along the lines you suggest.
A patch with equivalent functionality has been applied in version 4204.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.