|Subject:||bad $] threshold in test|
|Date:||Wed, 9 Aug 2017 18:14:16 +0100|
|To:||bug-Math-BigInt [...] rt.cpan.org|
|From:||Zefram <zefram [...] fysh.org>|
Math-BigInt's t/bigintpm.inc has some logic to skip some tests on Perl 5.6, due to its differing treatment of integer arithmetic. Unfortunately the $] threshold is affected by core bug [perl #72210], causing the logic to fail to skip on some configurations of Perl 5.6.2, yielding false test failures. The workaround for that is to stringify $] before performing a numeric comparison. But the threshold was actually in the wrong place anyway: to be strictly correct, the relevant change of numeric semantics happened in 5.7.1, not just after 5.6.2. The attached patch fixes both issues. -zefram
Message body is not shown because sender requested not to inline it.