Skip Menu |
 

This queue is for tickets about the Net-Ident CPAN distribution.

Report information
The Basics
Id: 12273
Status: resolved
Priority: 0/
Queue: Net-Ident

People
Owner: TODDR [...] cpan.org
Requestors: robert.pitt [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: 1.21



Subject: Won't install, fails tests.
Download (untitled) / with headers
text/plain 287b
Using Slackware Linux current, perl 5.8.6. Exactly the same problem as on this webpage: http://ppm.activestate.com/BuildStatus/5.8-hpux/hpux-ia64-5.8/Net-Ident-1.20.txt I have also noticed this module being rejected by perltest before with the same issue but have lost the URL for it.
Download (untitled) / with headers
text/plain 402b
[guest - Wed Apr 13 15:55:47 2005]: Show quoted text
> Using Slackware Linux current, perl 5.8.6. > > Exactly the same problem as on this webpage: > > http://ppm.activestate.com/BuildStatus/5.8-hpux/hpux-ia64-5.8/Net- > Ident-1.20.txt > > I have also noticed this module being rejected by perltest before with > the same issue but have lost the URL for it.
I have exactly the same problem, but using Debian Linux.
From: jonathan [...] barumtrading.co.uk
Download (untitled) / with headers
text/plain 526b
[guest - Fri Apr 29 06:58:46 2005]: Show quoted text
> [guest - Wed Apr 13 15:55:47 2005]: >
> > Using Slackware Linux current, perl 5.8.6. > > > > Exactly the same problem as on this webpage: > > > > http://ppm.activestate.com/BuildStatus/5.8-hpux/hpux-ia64-5.8/Net- > > Ident-1.20.txt > > > > I have also noticed this module being rejected by perltest before
> with
> > the same issue but have lost the URL for it.
> > > I have exactly the same problem, but using Debian Linux.
I too have the same issues: Fedora Core 2, Perl 5.8.7
From: jonathan [...] barumtrading.co.uk
Download (untitled) / with headers
text/plain 712b
[guest - Tue Dec 13 10:03:15 2005]: Show quoted text
> [guest - Fri Apr 29 06:58:46 2005]: >
> > [guest - Wed Apr 13 15:55:47 2005]: > >
> > > Using Slackware Linux current, perl 5.8.6. > > > > > > Exactly the same problem as on this webpage: > > > > > > http://ppm.activestate.com/BuildStatus/5.8-hpux/hpux-ia64-5.8/Net- > > > Ident-1.20.txt > > > > > > I have also noticed this module being rejected by perltest before
> > with
> > > the same issue but have lost the URL for it.
> > > > > > I have exactly the same problem, but using Debian Linux.
I too have the same issues: Fedora Core 2, Perl 5.8.7 I also have an additional error: t/Ident.....ok 5.8Use of uninitialised value in string eq at t/Ident.t line 152.
Download (untitled) / with headers
text/plain 259b
I have seen this on many systems, and I wonder if this module is supported any more: the last update was 6 years ago and it has these installation problems. SpamAssassin likes to use Net::Ident, I wonder if the SpamAssassin authors should use something else.
From: batailic [...] gmail.com
Download (untitled) / with headers
text/plain 1.2k
On Wed Apr 13 15:55:47 2005, guest wrote: Show quoted text
> Using Slackware Linux current, perl 5.8.6. > > Exactly the same problem as on this webpage: > > http://ppm.activestate.com/BuildStatus/5.8-hpux/hpux-ia64-5.8/Net- > Ident-1.20.txt > > I have also noticed this module being rejected by perltest before with > the same issue but have lost the URL for it.
Net::Ident::_export_hooks() called too early to check prototype error is there because _export_hooks is called before declaration. You can fix it by editing blib/lib/Net/Ident.pm before make and cutting sub _export_hooks and pasting it before _export_hooks() call like this: # provide import magic sub _export_hooks () { my($tag, $hook); while ( ($tag, $hook) = each %EXPORT_HOOKS ) { my $hookname = "_export_hook_$tag"; # pseudo-function name $EXPORT_TAGS{$tag} = [$hookname]; push @EXPORT_OK, $hookname; push @EXPORT_FAIL, $hookname; } } # put the export hooks in the standard Exporter structures _export_hooks(); While you are at it you could also edit t/hosts and comment out old non functional hard coded hosts that causes make test to fail and leave only localhost: #pc.xs4all.nl #xs4all.nl #lyrix.xs4all.nl #lysator.liu.se 127.0.0.1
RT-Send-CC: batailic [...] gmail.com, jonathan [...] barumtrading.co.uk
I have co-maintainership on this module. Can someone suggest a patch on this?
From: batailic [...] gmail.com
Download (untitled) / with headers
text/plain 1.9k
On Mon Jun 07 00:28:32 2010, TODDR wrote: Show quoted text
> I have co-maintainership on this module. Can someone suggest a patch > on this?
Patch using cat hosts.diff | patch -p2: **** Start of Ident.pm.diff **** --- ../Net-Ident-1.20/Ident.pm 1999-08-27 00:58:15.000000000 +0200 +++ ../Net-Ident-1.20.new/Ident.pm 2010-06-08 21:46:50.774365267 +0200 @@ -25,6 +25,17 @@ 'debug' => \&_set_debug, ); +# provide import magic +sub _export_hooks () { + my($tag, $hook); + while ( ($tag, $hook) = each %EXPORT_HOOKS ) { + my $hookname = "_export_hook_$tag"; # pseudo-function name + $EXPORT_TAGS{$tag} = [$hookname]; + push @EXPORT_OK, $hookname; + push @EXPORT_FAIL, $hookname; + } +} + # put the export hooks in the standard Exporter structures _export_hooks(); # for compatibility mode, uncomment the next line @@ s/^#\s*// @@ @@ -504,17 +515,6 @@ $self->{error}; } -# provide import magic -sub _export_hooks () { - my($tag, $hook); - while ( ($tag, $hook) = each %EXPORT_HOOKS ) { - my $hookname = "_export_hook_$tag"; # pseudo-function name - $EXPORT_TAGS{$tag} = [$hookname]; - push @EXPORT_OK, $hookname; - push @EXPORT_FAIL, $hookname; - } -} - # this is called whenever a function in @EXPORT_FAIL is imported. # simply calls the installed export hooks from %EXPORT_HOOKS, or # passes along the export_fail up the inheritance chain **** End of Ident.pm.diff **** **** Start of hosts.diff **** --- ../Net-Ident-1.20/t/hosts 1999-03-08 23:35:20.000000000 +0100 +++ ../Net-Ident-1.20.new/t/hosts 2010-06-08 21:49:56.782487010 +0200 @@ -4,8 +4,8 @@ # note that these tests actually rely on a common buglet in identd # implementations, in that they let you perform an ident lookup on # a connection that is incoming. -pc.xs4all.nl -xs4all.nl -lyrix.xs4all.nl -lysator.liu.se +#pc.xs4all.nl +#xs4all.nl +#lyrix.xs4all.nl +#lysator.liu.se 127.0.0.1 **** End of hosts.diff ****
RT-Send-CC: batailic [...] gmail.com
That's probably the least intrustive fix. Committed to repo.
Fixed in 1.21


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.