Skip Menu |
 

This queue is for tickets about the DBIx-Class CPAN distribution.

Report information
The Basics
Id: 122544
Status: rejected
Priority: 0/
Queue: DBIx-Class

People
Owner: Nobody in particular
Requestors: francisco [...] obispo.link
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: view_definition is being populated on server views
Date: Wed, 19 Jul 2017 15:11:18 -0700
To: bug-DBIx-Class [...] rt.cpan.org
From: "Francisco Obispo" <francisco [...] obispo.link>
Download (untitled) / with headers
text/plain 1.4k
When using `dbicdump` the resulting `::Result::` package (.pm), contains the `view_definition` even though it’s a server side view. This is new behavior, and for server views that are big, the schema is inflated in size, yielding higher memory usage. If it’s not a `virtual` view the definition should be omitted, or at least provide a switch to turn this behavior off. see: ```perl __PACKAGE__->table("v_notification_user"); __PACKAGE__->result_source_instance->view_definition(" SELECT ev.created_date,\n u.id AS user_id,\n u.login AS user_login,\n a.id AS account_id,\n a.name AS account_name,\n cat.name AS category_name,\n subcat.name AS subcategory_name,\n subcat.descr AS subcategory_descr,\n sev.name AS severity_name,\n sev.id AS severity_id,\n (n.viewed_date IS NOT NULL) AS is_read,\n n.guid,\n ev.message,\n ev.object,\n ev.url,\n floor(((date_part('epoch'::text, now()) - date_part('epoch'::text, ev.created_date)) / (86400)::double precision)) AS age_days,\n n.website_show\n FROM ((((((notification_event ev\n JOIN notification n ON ((n.event_id = ev.id)))\n JOIN account a ON ((a.id = ev.account_id)))\n JOIN \"user\" u ON ((u.id = n.user_id)))\n JOIN notification_subcategory subcat ON ((ev.subcategory_id = subcat.id)))\n JOIN notification_category cat ON ((cat.id = subcat.category_id)))\n JOIN notification_severity sev ON ((sev.id = ev.severity_id)))"); ``` Best regards
Download (untitled) / with headers
text/plain 214b
This is a feature request for DBIx::Class::Schema::Loader so I'm killing the ticket in the DBIx::Class queue; let's finish discussing it on the list and then we can get a more useful ticket filed in the right spot.
Subject: Re: [rt.cpan.org #122544] view_definition is being populated on server views
Date: Fri, 21 Jul 2017 15:03:49 -0700
To: "Matt S Trout via RT" <bug-DBIx-Class [...] rt.cpan.org>
From: "Francisco Obispo" <francisco [...] obispo.link>
Download (untitled) / with headers
text/plain 363b
Sounds good, thanks On 21 Jul 2017, at 12:37, Matt S Trout via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=122544 > > > This is a feature request for DBIx::Class::Schema::Loader so I'm > killing the ticket in the DBIx::Class queue; let's finish discussing > it on the list and then we can get a more useful ticket filed in the > right spot.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.