Skip Menu |
 

This queue is for tickets about the Perl-Tidy CPAN distribution.

Report information
The Basics
Id: 122030
Status: open
Priority: 0/
Queue: Perl-Tidy

People
Owner: Nobody in particular
Requestors: irilis.aelae [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Perl::Tidy sometimes does not call binmode
Date: Wed, 7 Jun 2017 16:30:19 +0300
To: bug-Perl-Tidy [...] rt.cpan.org
From: Irilis Aelae <irilis.aelae [...] gmail.com>
Download (untitled) / with headers
text/plain 969b
perltidy v20170521 perl 5, version 24, subversion 1 (v5.24.1) built for MSWin32-x64-multi-thread Binary build 2402 [401627] provided by ActiveState http://www.ActiveState.com Built Jan 5 2017 02:08:02 OS: Windows 8.1 perltidy arguments: --character-encoding=none (default) without --standard-output --output-line-ending=unix or --preserve-line-endings with unix line endings. Bug description: when called with above arguments Perl::Tidy::LineSink::new does not call binmode for output file. Result: under windows, line endings ignore setting --output-line-ending=unix and change to windows default. My patch: add this Show quoted text
> else { > if ( ref($fh) eq 'IO::File' ) { > $fh->binmode(); > } > elsif ( $output_file eq '-' ) { > binmode STDOUT; > } > }
into Perl::Tidy::LineSink::new after Show quoted text
> elsif ( $output_file eq '-' ) { binmode STDOUT }
Subject: Re: [rt.cpan.org #122030] Perl::Tidy sometimes does not call binmode
Date: Wed, 7 Jun 2017 07:14:38 -0700
To: bug-Perl-Tidy [...] rt.cpan.org
From: Steven Hancock <s7078hancock [...] gmail.com>
Download (untitled) / with headers
text/plain 1.5k
Thanks for the bug report and patch. Steve On 6/7/17, Irilis Aelae via RT <bug-Perl-Tidy@rt.cpan.org> wrote: Show quoted text
> Wed Jun 07 09:30:37 2017: Request 122030 was acted upon. > Transaction: Ticket created by irilis.aelae@gmail.com > Queue: Perl-Tidy > Subject: Perl::Tidy sometimes does not call binmode > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: irilis.aelae@gmail.com > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=122030 > > > > perltidy v20170521 > > perl 5, version 24, subversion 1 (v5.24.1) built for > MSWin32-x64-multi-thread > Binary build 2402 [401627] provided by ActiveState > http://www.ActiveState.com > Built Jan 5 2017 02:08:02 > > OS: Windows 8.1 > > perltidy arguments: > --character-encoding=none (default) > without --standard-output > --output-line-ending=unix or --preserve-line-endings with unix line > endings. > > Bug description: when called with above arguments Perl::Tidy::LineSink::new > does not call binmode for output file. > > Result: under windows, line endings ignore setting > --output-line-ending=unix and change to windows default. > > My patch: > add this >
>> else { >> if ( ref($fh) eq 'IO::File' ) { >> $fh->binmode(); >> } >> elsif ( $output_file eq '-' ) { >> binmode STDOUT; >> } >> }
> > into Perl::Tidy::LineSink::new after >
>> elsif ( $output_file eq '-' ) { binmode STDOUT }
> >
Subject: Re: [rt.cpan.org #122030] AutoReply: Perl::Tidy sometimes does not call binmode
Date: Wed, 7 Jun 2017 17:30:49 +0300
To: bug-Perl-Tidy [...] rt.cpan.org
From: Irilis Aelae <irilis.aelae [...] gmail.com>
Looked at my patch again, noticed it's a bit redundant. New version: add elsif ( ref($fh) eq 'IO::File' ) { $fh->binmode(); } just before elsif ( $output_file eq '-' ) { binmode STDOUT } 2017-06-07 16:30 GMT+03:00 Bugs in Perl-Tidy via RT < bug-Perl-Tidy@rt.cpan.org>: Show quoted text
> > Greetings, > > This message has been automatically generated in response to the > creation of a trouble ticket regarding: > "Perl::Tidy sometimes does not call binmode", > a summary of which appears below. > > There is no need to reply to this message right now. Your ticket has been > assigned an ID of [rt.cpan.org #122030]. Your ticket is accessible > on the web at: > > https://rt.cpan.org/Ticket/Display.html?id=122030 > > Please include the string: > > [rt.cpan.org #122030] > > in the subject line of all future correspondence about this issue. To do > so, > you may reply to this message. > > Thank you, > bug-Perl-Tidy@rt.cpan.org > > ------------------------------------------------------------------------- > perltidy v20170521 > > perl 5, version 24, subversion 1 (v5.24.1) built for > MSWin32-x64-multi-thread > Binary build 2402 [401627] provided by ActiveState > http://www.ActiveState.com > Built Jan 5 2017 02:08:02 > > OS: Windows 8.1 > > perltidy arguments: > --character-encoding=none (default) > without --standard-output > --output-line-ending=unix or --preserve-line-endings with unix line > endings. > > Bug description: when called with above arguments Perl::Tidy::LineSink::new > does not call binmode for output file. > > Result: under windows, line endings ignore setting > --output-line-ending=unix and change to windows default. > > My patch: > add this >
> > else { > > if ( ref($fh) eq 'IO::File' ) { > > $fh->binmode(); > > } > > elsif ( $output_file eq '-' ) { > > binmode STDOUT; > > } > > }
> > into Perl::Tidy::LineSink::new after >
> > elsif ( $output_file eq '-' ) { binmode STDOUT }
>


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.