Skip Menu |
 

This queue is for tickets about the File-Path CPAN distribution.

Report information
The Basics
Id: 121951
Status: open
Priority: 0/
Queue: File-Path

People
Owner: Nobody in particular
Requestors: jkeenan [...] pobox.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments
0001-Prevent-directory-chmod-race-attack.patch



Subject: Vulnerability in rmtree() and remove_tree(): CVE-2017-6512
Date: Wed, 31 May 2017 19:47:12 -0400
To: bug-File-Path [...] rt.cpan.org
From: James E Keenan <jkeenan [...] pobox.com>
Download (untitled) / with headers
text/plain 909b
This ticket will serve as a placeholder for public discussion of a security vulnerability in File-Path originally reported by the cPanel Security Team on February 28 2017. This vulnerability has been assigned the following ID: CVE-2017-6512 In the rmtree() and remove_tree() functions, the chmod()logic to make directories traversable can be abused to set the mode on an attacker-chosen file to an attacker-chosen value. This is due to the time-of-check-to-time-of-use (TOCTTOU) race condition (https://en.wikipedia.org/wiki/Time_of_check_to_time_of_use) between the stat() that decides the inode is a directory and the chmod() that tries to make it user-rwx. The vulnerability has been addressed with the upload to CPAN of File-Path version 2.13. We will use this RT, among other things, to record links to web pages where this vulnerability is discussed or addressed. Thank you very much. Jim Keenan
Download (untitled) / with headers
text/plain 134b
I've attached what I believe to be the original patch from John Lightsey, taken from https://github.com/jkeenan/File-Path/commits/2.13
Subject: 0001-Prevent-directory-chmod-race-attack.patch
From e5ef95276ee8ad471c66ee574a5d42552b3a6af2 Mon Sep 17 00:00:00 2001 From: John Lightsey <john@nixnuts.net> Date: Tue, 2 May 2017 12:03:52 -0500 Subject: [PATCH] Prevent directory chmod race attack. CVE-2017-6512 is a race condition attack where the chmod() of directories that cannot be entered is misused to change the permissions on other files or directories on the system. This has been corrected by limiting the directory-permission loosening logic to systems where fchmod() is supported. --- lib/File/Path.pm | 39 +++++++++++++++++++++++++-------------- t/Path.t | 42 +++++++++++++++++++++++++++--------------- 2 files changed, 52 insertions(+), 29 deletions(-) diff --git a/lib/File/Path.pm b/lib/File/Path.pm index c7d7eb8..7fc44c6 100644 --- a/lib/File/Path.pm +++ b/lib/File/Path.pm @@ -400,21 +400,32 @@ sub _rmtree { # see if we can escalate privileges to get in # (e.g. funny protection mask such as -w- instead of rwx) - $perm &= oct '7777'; - my $nperm = $perm | oct '700'; - if ( - !( - $data->{safe} - or $nperm == $perm - or chmod( $nperm, $root ) - ) - ) - { - _error( $data, - "cannot make child directory read-write-exec", $canon ); - next ROOT_DIR; + # This uses fchmod to avoid traversing outside of the proper + # location (CVE-2017-6512) + my $root_fh; + if (open($root_fh, '<', $root)) { + my ($fh_dev, $fh_inode) = (stat $root_fh )[0,1]; + $perm &= oct '7777'; + my $nperm = $perm | oct '700'; + local $@; + if ( + !( + $data->{safe} + or $nperm == $perm + or !-d _ + or $fh_dev ne $ldev + or $fh_inode ne $lino + or eval { chmod( $nperm, $root_fh ) } + ) + ) + { + _error( $data, + "cannot make child directory read-write-exec", $canon ); + next ROOT_DIR; + } + close $root_fh; } - elsif ( !chdir($root) ) { + if ( !chdir($root) ) { _error( $data, "cannot chdir to child", $canon ); next ROOT_DIR; } diff --git a/t/Path.t b/t/Path.t index 25a06f1..29d4e48 100644 --- a/t/Path.t +++ b/t/Path.t @@ -3,7 +3,7 @@ use strict; -use Test::More tests => 168; +use Test::More tests => 167; use Config; use Fcntl ':mode'; use lib './t'; @@ -26,6 +26,13 @@ BEGIN { my $Is_VMS = $^O eq 'VMS'; +my $fchmod_supported = 0; +if (open my $fh, curdir()) { + my ($perm) = (stat($fh))[2]; + $perm &= 07777; + eval { $fchmod_supported = chmod( $perm, $fh); }; +} + # first check for stupid permissions second for full, so we clean up # behind ourselves for my $perm (0111,0777) { @@ -307,16 +314,19 @@ is($created[0], $dir, "created directory (old style 3 mode undef) cross-check"); is(rmtree($dir, 0, undef), 1, "removed directory 3 verbose undef"); -$dir = catdir($tmp_base,'G'); -$dir = VMS::Filespec::unixify($dir) if $Is_VMS; +SKIP: { + skip "fchmod of directories not supported on this platform", 3 unless $fchmod_supported; + $dir = catdir($tmp_base,'G'); + $dir = VMS::Filespec::unixify($dir) if $Is_VMS; -@created = mkpath($dir, undef, 0200); + @created = mkpath($dir, undef, 0400); -is(scalar(@created), 1, "created write-only dir"); + is(scalar(@created), 1, "created read-only dir"); -is($created[0], $dir, "created write-only directory cross-check"); + is($created[0], $dir, "created read-only directory cross-check"); -is(rmtree($dir), 1, "removed write-only dir"); + is(rmtree($dir), 1, "removed read-only dir"); +} # borderline new-style heuristics if (chdir $tmp_base) { @@ -458,26 +468,28 @@ SKIP: { } SKIP : { - my $skip_count = 19; + my $skip_count = 18; # this test will fail on Windows, as per: # http://perldoc.perl.org/perlport.html#chmod skip "Windows chmod test skipped", $skip_count if $^O eq 'MSWin32'; + skip "fchmod() on directories is not supported on this platform", $skip_count + unless $fchmod_supported; my $mode; my $octal_mode; my @inputs = ( - 0777, 0700, 0070, 0007, - 0333, 0300, 0030, 0003, - 0111, 0100, 0010, 0001, - 0731, 0713, 0317, 0371, 0173, 0137, - 00 ); + 0777, 0700, 0470, 0407, + 0433, 0400, 0430, 0403, + 0111, 0100, 0110, 0101, + 0731, 0713, 0317, 0371, + 0173, 0137); my $input; my $octal_input; - $dir = catdir($tmp_base, 'chmod_test'); foreach (@inputs) { $input = $_; + $dir = catdir($tmp_base, sprintf("chmod_test%04o", $input)); # We can skip from here because 0 is last in the list. skip "Mode of 0 means assume user defaults on VMS", 1 if ($input == 0 && $Is_VMS); @@ -489,7 +501,7 @@ SKIP : { skip "permissions are not fully supported by the filesystem", 1 if (($^O eq 'MSWin32' || $^O eq 'cygwin') && ((Win32::FsType())[1] & 8) == 0); is($octal_mode,$input, "create a new directory with chmod $input ($octal_input)"); - } + } rmtree( $dir ); } } -- 2.1.4
Download (untitled) / with headers
text/plain 587b
On Wed May 31 20:27:12 2017, JKEENAN wrote: Show quoted text
Tracking in RedHat Linux: https://bugzilla.redhat.com/show_bug.cgi?id=1457832


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.