Skip Menu |
 

This queue is for tickets about the Net-SSLeay CPAN distribution.

Report information
The Basics
Id: 121915
Status: open
Priority: 0/
Queue: Net-SSLeay

People
Owner: chrisn [...] cpan.org
Requestors: ETJ [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.81
Fixed in: (no value)



Subject: [PATCH] Configure and also build fail in "place with space"
Download (untitled) / with headers
text/plain 1.1k
Apologies for not using correct patch format but have forgotten how to operate svn. The configure stage can be fixed by changing the line in check_openssl_version inside inc/Module/Install/PRIVATE/Net/SSLeay.pm to read: open($pipe, qq{"$exec" version |}) The build stage can be fixed by changing this: $self->makemaker_args( CCCDLFLAGS => $opts->{cccdlflags}, OPTIMIZE => $opts->{optimize}, INC => join(' ', map {"-I$_"} @{$opts->{inc_paths}}), LIBS => join(' ', (map {"-L$_"} @{$opts->{lib_paths}}), (map {"-l$_"} @{$opts->{lib_links}})), ); to this: $self->makemaker_args( CCCDLFLAGS => $opts->{cccdlflags}, OPTIMIZE => $opts->{optimize}, INC => join(' ', map qq{"-I$_"}, @{$opts->{inc_paths}}), LIBS => join(' ', (map qq{"-L$_"}, @{$opts->{lib_paths}}), (map {"-l$_"} @{$opts->{lib_links}})), ); and this: # From HMBRAND to handle multple version of OPENSSL installed if (my $lp = join " " => map { "-L$_" } @{$opts->{lib_paths} || []}) to this: # From HMBRAND to handle multple version of OPENSSL installed if (my $lp = join " " => map qq{"-L$_"}, @{$opts->{lib_paths} || []})
Subject: Re: [rt.cpan.org #121915] [PATCH] Configure and also build fail in "place with space"
Date: Wed, 31 May 2017 19:53:24 +1000
To: bug-Net-SSLeay [...] rt.cpan.org
From: Mike McCauley <mikem [...] airspayce.com>
Download (untitled) / with headers
text/plain 1.8k
Thanks for this patch. It is now in SVN 495 On Saturday, 27 May 2017 9:30:04 PM AEST you wrote: Show quoted text
> Sat May 27 21:29:57 2017: Request 121915 was acted upon. > Transaction: Ticket created by ETJ > Queue: Net-SSLeay > Subject: [PATCH] Configure and also build fail in "place with space" > Broken in: 1.81 > Severity: (no value) > Owner: Nobody > Requestors: ETJ@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=121915 > > > > Apologies for not using correct patch format but have forgotten how to > operate svn. > > The configure stage can be fixed by changing the line in > check_openssl_version inside inc/Module/Install/PRIVATE/Net/SSLeay.pm to > read: > > open($pipe, qq{"$exec" version |}) > > The build stage can be fixed by changing this: > > $self->makemaker_args( > CCCDLFLAGS => $opts->{cccdlflags}, > OPTIMIZE => $opts->{optimize}, > INC => join(' ', map {"-I$_"} @{$opts->{inc_paths}}), > LIBS => join(' ', (map {"-L$_"} @{$opts->{lib_paths}}), (map > {"-l$_"} @{$opts->{lib_links}})), ); > > to this: > > $self->makemaker_args( > CCCDLFLAGS => $opts->{cccdlflags}, > OPTIMIZE => $opts->{optimize}, > INC => join(' ', map qq{"-I$_"}, @{$opts->{inc_paths}}), > LIBS => join(' ', (map qq{"-L$_"}, @{$opts->{lib_paths}}), (map > {"-l$_"} @{$opts->{lib_links}})), ); > > and this: > > # From HMBRAND to handle multple version of OPENSSL installed > if (my $lp = join " " => map { "-L$_" } @{$opts->{lib_paths} || []}) > > to this: > > # From HMBRAND to handle multple version of OPENSSL installed > if (my $lp = join " " => map qq{"-L$_"}, @{$opts->{lib_paths} || []})
-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474
Download (untitled) / with headers
text/plain 157b
On Wed May 31 05:53:59 2017, mikem@airspayce.com wrote: Show quoted text
> Thanks for this patch. > It is now in SVN 495
Great, thanks! Could I ask when it will be released?
Subject: Re: [rt.cpan.org #121915] [PATCH] Configure and also build fail in "place with space"
Date: Thu, 01 Jun 2017 08:41:51 +1000
To: bug-Net-SSLeay [...] rt.cpan.org
From: Mike McCauley <mikem [...] airspayce.com>
Download (untitled) / with headers
text/plain 567b
Hi, should be very soon, perhaps the next few days On Wednesday, 31 May 2017 11:29:54 AM AEST you wrote: Show quoted text
> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=121915 > > > On Wed May 31 05:53:59 2017, mikem@airspayce.com wrote:
> > Thanks for this patch. > > It is now in SVN 495
> > Great, thanks! Could I ask when it will be released?
-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474
Download (untitled) / with headers
text/plain 776b
On Wed May 31 18:42:07 2017, mikem@airspayce.com wrote: Show quoted text
> Hi, > > should be very soon, perhaps the next few days > > On Wednesday, 31 May 2017 11:29:54 AM AEST you wrote:
> > Queue: Net-SSLeay > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=121915 > > > > > On Wed May 31 05:53:59 2017, mikem@airspayce.com wrote:
> > > Thanks for this patch. > > > It is now in SVN 495
> > > > Great, thanks! Could I ask when it will be released?
> >
I just tried latest dev release from last week, and this is still broken. Also I see no sign of the change on the github repo. Also you marked it as fixed in 1.82 which is from last year and therefore not correct. Would it help if I PR against the new GH repo, https://github.com/radiator-software/p5-net-ssleay ?
Download (untitled) / with headers
text/plain 1.3k
On Mon Jul 09 16:13:03 2018, ETJ wrote: Show quoted text
> On Wed May 31 18:42:07 2017, mikem@airspayce.com wrote:
> > Hi, > > > > should be very soon, perhaps the next few days > > > > On Wednesday, 31 May 2017 11:29:54 AM AEST you wrote:
> > > Queue: Net-SSLeay > > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=121915 > > > > > > > On Wed May 31 05:53:59 2017, mikem@airspayce.com wrote:
> > > > Thanks for this patch. > > > > It is now in SVN 495
> > > > > > Great, thanks! Could I ask when it will be released?
> > > >
> > I just tried latest dev release from last week, and this is still > broken. Also I see no sign of the change on the github repo. Also you > marked it as fixed in 1.82 which is from last year and therefore not > correct. > > Would it help if I PR against the new GH repo, > https://github.com/radiator-software/p5-net-ssleay ?
Mike did indeed make those changes in SVN revision 495 (which is now Git commit 51faa64: https://github.com/radiator-software/p5-net-ssleay/commit/51faa649b4685801f52396c276402daa12fe9668). I'm one of the new maintainers of Net-SSLeay, and I've been closing old RT bugs that have had patches applied but their associated bug reports left open. If the functionality's still broken, it's likely that the patch was incomplete - thanks for identifying that this is still an issue and reopening the bug, we'll fix this before the next stable release.
Download (untitled) / with headers
text/plain 383b
I've looked into this further, and it appears that the map-related changes made by this patch in inc/Module/Install/PRIVATE/Net/SSLeay.pm were later reverted as part of a large number of changes made in SVN revision 502 (Git commit 89d180d). This was labelled as a bugfix in the commit message, so I'll have to do some more digging to find out exactly what bug was being fixed there.
Download (untitled) / with headers
text/plain 574b
On Mon Jul 09 18:44:19 2018, CHRISN wrote: Show quoted text
> I've looked into this further, and it appears that the map-related > changes made by this patch in inc/Module/Install/PRIVATE/Net/SSLeay.pm > were later reverted as part of a large number of changes made in SVN > revision 502 (Git commit 89d180d). This was labelled as a bugfix in > the commit message, so I'll have to do some more digging to find out > exactly what bug was being fixed there.
I will bet any money it was simply the SVN equivalent of a force-push, rather than deliberate. I will submit my changes again as a PR.
Download (untitled) / with headers
text/plain 918b
On Tue Jul 10 05:17:15 2018, ETJ wrote: Show quoted text
> On Mon Jul 09 18:44:19 2018, CHRISN wrote:
> > I've looked into this further, and it appears that the map-related > > changes made by this patch in > > inc/Module/Install/PRIVATE/Net/SSLeay.pm > > were later reverted as part of a large number of changes made in SVN > > revision 502 (Git commit 89d180d). This was labelled as a bugfix in > > the commit message, so I'll have to do some more digging to find out > > exactly what bug was being fixed there.
> > I will bet any money it was simply the SVN equivalent of a force-push, > rather than deliberate. I will submit my changes again as a PR.
On further inspection, the commit message just baldly says it is not quoting those paths, claiming doing so is a bug. It is not. I have PRed the code on https://github.com/radiator-software/p5-net-ssleay/pull/12, but Travis is showing errors. I will look more at these in a bit.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.