Skip Menu |
 

This queue is for tickets about the Coro CPAN distribution.

Report information
The Basics
Id: 121836
Status: new
Priority: 0/
Queue: Coro

People
Owner: Nobody in particular
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 6.511
Fixed in: (no value)

Attachments
Coro-6.511-Adjust-comppad_name_-variable-sizes-to-Perl-5.26.0.patch



Subject: Tests fail with Perl 5.26.0 RC1: Coro thread context slot 'comppad_name_fill' too small for this version of perl
Download (untitled) / with headers
text/plain 1.1k
Tests on Perl 5.26.0 RC1 on x86_64 platform fails with: make[1]: Entering directory '/builddir/build/BUILD/Coro-6.511/Event' "/usr/bin/perl" -MExtUtils::Command::MM -e 'cp_nonempty' -- Event.bs ../blib/arch/auto/Coro/Event/Event.bs 644 PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, '../blib/lib', '../blib/arch')" t/*.t FATAL: Coro thread context slot 'comppad_name_fill' too small for this version of perl. at /usr/lib64/perl5/DynaLoader.pm line 210. BEGIN failed--compilation aborted at /builddir/build/BUILD/Coro-6.511/Event/../blib/lib/Coro/State.pm line 114. Compilation failed in require at /builddir/build/BUILD/Coro-6.511/Event/../blib/lib/Coro.pm line 363. BEGIN failed--compilation aborted at /builddir/build/BUILD/Coro-6.511/Event/../blib/lib/Coro.pm line 363. Compilation failed in require at t/00_basic.t line 5. BEGIN failed--compilation aborted at t/00_basic.t line 5. t/00_basic.t .... Dubious, test returned 2 (wstat 512, 0x200) Failed 5/5 subtests This is caused by change in perl sources (v5.25.5-30-gd12be05 commit). A fix for Coro is attached.
Subject: Coro-6.511-Adjust-comppad_name_-variable-sizes-to-Perl-5.26.0.patch
From b48bc3a8141e5f27ce48b6f3ebbe2ba6ee7bda94 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Tue, 23 May 2017 15:12:06 +0200 Subject: [PATCH] Adjust comppad_name_ variable sizes to Perl 5.26.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Perl 5.26.0 changed some variable types in this commit: commit d12be05dd0210a08e077f0cc9586a5a963122547 Author: David Mitchell <davem@iabyn.com> Date: Mon Sep 26 15:56:08 2016 +0100 make PL_ pad vars be of type PADOFFSET Now that that PADOFFSET is signed, make PL_comppad_name_fill PL_comppad_name_floor PL_padix PL_constpadix PL_padix_floor PL_min_intro_pending PL_max_intro_pending be of type PADOFFSET rather than I32, to match the rest of the pad interface. At the same time, change various I32 local vars in pad.c functions to be PADOFFSET. This patch adjusts Coro to the changes. Signed-off-by: Petr Písař <ppisar@redhat.com> --- Coro/state.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Coro/state.h b/Coro/state.h index 9a3e84f..8d6d067 100644 --- a/Coro/state.h +++ b/Coro/state.h @@ -83,8 +83,13 @@ VAR(compcv, CV *) /* currently compiling subroutine */ VAR(comppad, AV *) /* storage for lexically scoped temporaries */ VAR(comppad_name, AV *) /* variable names for "my" variables */ +#if PERL_VERSION_ATLEAST (5,25,6) +VAR(comppad_name_fill, PADOFFSET) /* last "introduced" variable offset */ +VAR(comppad_name_floor, PADOFFSET) /* start of vars in innermost block */ +#else VAR(comppad_name_fill, I32) /* last "introduced" variable offset */ VAR(comppad_name_floor, I32) /* start of vars in innermost block */ +#endif VAR(runops, runops_proc_t) /* for tracing support */ -- 2.9.4


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.