Skip Menu |
 

This queue is for tickets about the Test-Portability-Files CPAN distribution.

Report information
The Basics
Id: 12176
Status: open
Priority: 0/
Queue: Test-Portability-Files

People
Owner: SAPER [...] cpan.org
Requestors: rrwo [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.05
Fixed in: (no value)

Attachments


Subject: Distribution directory length is not tested for
Download (untitled) / with headers
text/plain 654b
Suppose::You::Have::A::Long::Module::Name, well, each subdirectory is under 32-characters so it passes tests, maybe t/Suppose-You-Have-A-Long-Module-Name.t fails the test but it's easy to rename that to a short name, you you still have it all in a folder called Suppose-You-Have-A-Long-Module-Name-0.123 or whatever that the current version of Test::Portability::Files doesn't test for I'm not entirely sure how you would test for it. I think the easiest way is to parse the META.yml for "name" and "version" tags, and check join("-",$meta{name},$meta{version}). Of course this should be an option that can be disabled. A patch is attached to do this.
Download Files.pm.diff
text/x-diff 1k
7a8 > use YAML qw(LoadFile); 11c12,13 < $VERSION = '0.05'; --- > $VERSION = '0.05_01'; > $VERSION = eval $VERSION; 47a50 > dist_path => 1, 77c80 < ."cause real problems on case-insensitive filesystems:", --- > ."cause real problems on case-insensitive filesystems:\n", 80a84 > dist_path => "The pathname of the distribution is too long:\n", 142a147,150 > C<test_dist_path> is enabled > > =item * > 241a250,254 > C<test_dist_path> - check the distribution name from the F<META.yml> file and > determne if it conforms with the other name limitations. > > =item * > 406a420,429 > > if($tests{dist_path}) { > if (-r "META.yml") { > my ($meta) = LoadFile("META.yml"); > test_name_portability(join("-", $meta->{name}, $meta->{version})); > } else { > # Should we complain or just ignore it when we can't read the > # META.yml file? > } > } 453c476 < Copyright 2004 SE<eacute>bastien Aperghis-Tramoni, All Rights Reserved. --- > Copyright 2004,2005 SE<eacute>bastien Aperghis-Tramoni, All Rights Reserved.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.