This queue is for tickets about the Test-Plan CPAN distribution.

Report information
The Basics
Id:
12147
Status:
resolved
Priority:
Low/Low
Queue:

People
Owner:
geoff [...] cpan.org
Requestors:
barbie [...] missbarbell.co.uk
Cc:
AdminCc:

BugTracker
Severity:
Important
Broken in:
0.02
Fixed in:
(no value)



Subject: test scripts not listed correctly for Win32
The attached patch is specifically for Makefile.PL. In listing the test scripts to run, you use '*.t'. However, this doesn't always work very well on Win32, and it can be better to list the test scripts individually.
--- C:\wip\diffs\Test-Plan\Test-Plan-0.02/Makefile.PL Tue Mar 15 14:37:58 2005 +++ C:\wip\diffs\Test-Plan\Test-Plan-0.02-barbie/Makefile.PL Tue Apr 5 14:56:36 2005 @@ -7,11 +7,11 @@ use File::Find qw(find); use File::Spec (); -my %directories; +my %scripts; -find(sub { return unless m/\.t$/; $directories{$File::Find::dir} = 1 }, 't'); +find(sub { return unless m/\.t$/; $scripts{$File::Find::name} = 1 }, 't'); -my @tests = map { File::Spec->catfile($_, '*.t') } keys %directories; +my @tests = keys %scripts; WriteMakefile( NAME => 'Test::Plan',
[BARBIE - Tue Apr 5 09:58:20 2005]:
Show quoted text
> The attached patch is specifically for Makefile.PL. In listing the > test scripts to run, you use '*.t'. However, this doesn't always > work very well on Win32, and it can be better to list the test > scripts individually.
your patch assumes that every file under t/ is a test file, which it may not be. but I'll try and work something up and include it in the next release. --Geoff
[GEOFF - Tue Apr 5 10:43:13 2005]:
Show quoted text
> [BARBIE - Tue Apr 5 09:58:20 2005]: >
> > The attached patch is specifically for Makefile.PL. In listing the > > test scripts to run, you use '*.t'. However, this doesn't always > > work very well on Win32, and it can be better to list the test > > scripts individually.
> > your patch assumes that every file under t/ is a test file, which it may > not be. but I'll try and work something up and include it in the next > release.
uh, forget what I just said :) I clearly need more coffee... thanks for the patch. --Geoff
this was fixed in Test-Plan-0.03, with attribution given to another user who reported the problem 6 months after you did. sorry about that. --Geoff


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.