Skip Menu |
 

This queue is for tickets about the Net-SSLeay CPAN distribution.

Report information
The Basics
Id: 121084
Status: open
Priority: 0/
Queue: Net-SSLeay

People
Owner: Nobody in particular
Requestors: JDDPAUSE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.81
Fixed in: (no value)



Subject: Search of openssl libraries on Windows
Download (untitled) / with headers
text/plain 218b
With openssl-1.1.0e, compiled in VC-WIN32 mode, link libraries are installed by default as libcrypto.lib and libssl.lib. In addition the code checking for Windows libraries has a bug (missing $). Patch in attachement.
Subject: SSLeay.pm.diff
Download SSLeay.pm.diff
text/x-diff 1.3k
diff -Naur Net-SSLeay-1.81.old/inc/Module/Install/PRIVATE/Net/SSLeay.pm Net-SSLeay-1.81.new/inc/Module/Install/PRIVATE/Net/SSLeay.pm --- Net-SSLeay-1.81.old/inc/Module/Install/PRIVATE/Net/SSLeay.pm 2017-01-08 04:34:51.000000000 +0100 +++ Net-SSLeay-1.81.new/inc/Module/Install/PRIVATE/Net/SSLeay.pm 2017-04-12 13:09:27.207003700 +0200 @@ -92,11 +92,11 @@ my @pairs = (); # Library names depend on the compiler @pairs = (['eay32','ssl32'],['crypto.dll','ssl.dll'],['crypto','ssl']) if $Config{cc} =~ /gcc/; - @pairs = (['libeay32','ssleay32'],['libeay32MD','ssleay32MD'],['libeay32MT','ssleay32MT']) if $Config{cc} =~ /cl/; + @pairs = (['libeay32','ssleay32'],['libeay32MD','ssleay32MD'],['libeay32MT','ssleay32MT'],['libcrypto','libssl']) if $Config{cc} =~ /cl/; for my $dir (@{$opts->{lib_paths}}) { for my $p (@pairs) { $found = 1 if ($Config{cc} =~ /gcc/ && -f "$dir/lib$p->[0].a" && -f "$dir/lib$p->[1].a"); - $found = 1 if ($Config{cc} =~ /cl/ && -f "$dir/$p->[0].lib" && -f "$dir/p->[1].lib"); + $found = 1 if ($Config{cc} =~ /cl/ && -f "$dir/$p->[0].lib" && -f "$dir/$p->[1].lib"); if ($found) { $opts->{lib_links} = [$p->[0], $p->[1], 'crypt32']; # Some systems need this system lib crypt32 too $opts->{lib_paths} = [$dir];
Subject: Re: [rt.cpan.org #121084] Search of openssl libraries on Windows
Date: Wed, 12 Apr 2017 20:56:56 +0100
To: bug-Net-SSLeay [...] rt.cpan.org
From: Mike McCauley <mikem [...] airspayce.com>
Hello. I won't be able to look into this for at least 6 weeks. Perhaps you can send a patch in the meantime Cheers Sent from my iPhone Show quoted text
> On 12 Apr 2017, at 12:13 pm, Jean-Damien Durand via RT <bug-Net-SSLeay@rt.cpan.org> wrote: > > Wed Apr 12 07:13:41 2017: Request 121084 was acted upon. > Transaction: Ticket created by JDDPAUSE > Queue: Net-SSLeay > Subject: Search of openssl libraries on Windows > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: JDDPAUSE@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=121084 > > > > With openssl-1.1.0e, compiled in VC-WIN32 mode, link libraries are installed by default as libcrypto.lib and libssl.lib. In addition the code checking for Windows libraries has a bug (missing $). > > Patch in attachement. > diff -Naur Net-SSLeay-1.81.old/inc/Module/Install/PRIVATE/Net/SSLeay.pm Net-SSLeay-1.81.new/inc/Module/Install/PRIVATE/Net/SSLeay.pm --- Net-SSLeay-1.81.old/inc/Module/Install/PRIVATE/Net/SSLeay.pm 2017-01-08 04:34:51.000000000 +0100 +++ Net-SSLeay-1.81.new/inc/Module/Install/PRIVATE/Net/SSLeay.pm 2017-04-12 13:09:27.207003700 +0200 @@ -92,11 +92,11 @@ my @pairs = (); # Library names depend on the compiler @pairs = (['eay32','ssl32'],['crypto.dll','ssl.dll'],['crypto','ssl']) if $Config{cc} =~ /gcc/; - @pairs = (['libeay32','ssleay32'],['libeay32MD','ssleay32MD'],['libeay32MT','ssleay32MT']) if $Config{cc} =~ /cl/; + @pairs = (['libeay32','ssleay32'],['libeay32MD','ssleay32MD'],['libeay32MT','ssleay32MT'],['libcrypto','libssl']) if $Config{cc} =~ /cl/; for my $dir (@{$opts->{lib_paths}}) { for my $p (@pairs) { $found = 1 if ($Config{cc} =~ /gcc/ && -f "$dir/lib$p->[0].a" && -f "$dir/lib$p->[1].a"); - $found = 1 if ($Config{cc} =~ /cl/ && -f "$dir/$p->[0].lib" && -f "$dir/p->[1].lib"); + $found = 1 if ($Config{cc} =~ /cl/ && -f "$dir/$p->[0].lib" && -f "$dir/$p->[1].lib"); if ($found) { $opts->{lib_links} = [$p->[0], $p->[1], 'crypt32']; # Some systems need this system lib crypt32 too $opts->{lib_paths} = [$dir];


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.