Skip Menu |
 

This queue is for tickets about the Net-SSLeay CPAN distribution.

Report information
The Basics
Id: 121083
Status: resolved
Priority: 0/
Queue: Net-SSLeay

People
Owner: MIKEM [...] cpan.org
Requestors: JDDPAUSE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.81
Fixed in: 1.82



Subject: Code portability
Download (untitled) / with headers
text/plain 159b
Code does not compile with cl and openssl-1.1.0e: SSLeay.xs(858) : error C2275: 'STRLEN' : illegal use of this type as an expression Patch in attachement.
Subject: SSLeay.xs.diff
Download SSLeay.xs.diff
text/x-diff 832b
diff -Naur Net-SSLeay-1.81.old/SSLeay.xs Net-SSLeay-1.81.new/SSLeay.xs --- Net-SSLeay-1.81.old/SSLeay.xs 2017-03-04 05:25:15.000000000 +0100 +++ Net-SSLeay-1.81.new/SSLeay.xs 2017-04-12 12:57:08.743941000 +0200 @@ -854,10 +854,12 @@ *cipher = sk_SSL_CIPHER_value(peer_ciphers, SvIV(pref_cipher)); #if OPENSSL_VERSION_NUMBER >= 0x10100000L - /* Use any new master secret set by the callback function in secret */ - STRLEN newsecretlen; - char* newsecretdata = SvPV(secretsv, newsecretlen); - memcpy(secret, newsecretdata, newsecretlen); + { + /* Use any new master secret set by the callback function in secret */ + STRLEN newsecretlen; + char* newsecretdata = SvPV(secretsv, newsecretlen); + memcpy(secret, newsecretdata, newsecretlen); + } #endif }
Download (untitled) / with headers
text/plain 381b
On Wed Apr 12 12:05:21 2017, JDDPAUSE wrote: Show quoted text
> Code does not compile with cl and openssl-1.1.0e: > > SSLeay.xs(858) : error C2275: 'STRLEN' : illegal use of this type as > an expression > > Patch in attachement.
Thanks for the patch - this was applied by the previous Net-SSLeay maintainer in SVN revision 501 (now Git commit 61b8686), which was included in stable release 1.82.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.