Skip Menu |
 

This queue is for tickets about the DateTime-Fiction-JRRTolkien-Shire CPAN distribution.

Report information
The Basics
Id: 120635
Status: patched
Priority: 0/
Queue: DateTime-Fiction-JRRTolkien-Shire

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in:
  • 0.900
  • 0.899_01
Fixed in: 0.900_02



Subject: Minimum DateTime version
Download (untitled) / with headers
text/plain 2.7k
Some of my smoker systems with older DateTime generate failures for this the 0.900 release of the distribution: ... PERL_DL_NONLAZY=1 "/usr/perl5.20.1Dp/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t Bailout called. Further testing stopped: # Failed test 'use DateTime::Fiction::JRRTolkien::Shire;' # at t/00load.t line 6. # Tried to use 'DateTime::Fiction::JRRTolkien::Shire'. # Error: Can't locate Specio/Exporter.pm in @INC (you may need to install the Specio::Exporter module) (@INC contains: /home/cpansand/.cpan/build/2017031618/DateTime-Fiction-JRRTolkien-Shire-0.900-OEYv1X/blib/lib /home/cpansand/.cpan/build/2017031618/DateTime-Fiction-JRRTolkien-Shire-0.900-OEYv1X/blib/arch /home/cpansand/.cpan/build/2017031618/Date-Tolkien-Shire-Data-0.001-CkoUh0/blib/arch /home/cpansand/.cpan/build/2017031618/Date-Tolkien-Shire-Data-0.001-CkoUh0/blib/lib /home/cpansand/.cpan/build/2017031618/Date-Tolkien-Shire-Data-0.001-CkoUh0/blib/arch /home/cpansand/.cpan/build/2017031618/Date-Tolkien-Shire-Data-0.001-CkoUh0/blib/lib /usr/perl5.20.1Dp/lib/site_perl/5.20.1/amd64-freebsd-ld /usr/perl5.20.1Dp/lib/site_perl/5.20.1 /usr/perl5.20.1Dp/lib/5.20.1/amd64-freebsd-ld /usr/perl5.20.1Dp/lib/5.20.1 .) at /usr/perl5.20.1Dp/lib/5.20.1/parent.pm line 20. # BEGIN failed--compilation aborted at /home/cpansand/.cpan/build/2017031618/DateTime-Fiction-JRRTolkien-Shire-0.900-OEYv1X/blib/lib/DateTime/Fiction/JRRTolkien/Shire/Types.pm line 8. # Compilation failed in require at /home/cpansand/.cpan/build/2017031618/DateTime-Fiction-JRRTolkien-Shire-0.900-OEYv1X/blib/lib/DateTime/Fiction/JRRTolkien/Shire.pm line 27. # BEGIN failed--compilation aborted at /home/cpansand/.cpan/build/2017031618/DateTime-Fiction-JRRTolkien-Shire-0.900-OEYv1X/blib/lib/DateTime/Fiction/JRRTolkien/Shire.pm line 27. # Compilation failed in require at t/00load.t line 6. # BEGIN failed--compilation aborted at t/00load.t line 6. FAILED--Further testing stopped. *** Error code 255 ... The result of statistical analysis (theta=0 means "bad"): **************************************************************** Regression 'mod:DateTime' **************************************************************** Name Theta StdErr T-stat [0='const'] 0.0000 0.0000 6.02 [1='eq_1.26'] -0.0000 0.0000 -4.17 [2='eq_1.28'] -0.0000 0.0000 -6.37 [3='eq_1.36'] 0.0000 0.0000 1.87 [4='eq_1.41'] 1.0000 0.0000 9170555433066562.00 [5='eq_1.42'] 1.0000 0.0000 10685077523296724.00 R^2= 1.000, N= 82, K= 6 **************************************************************** Probably the minimum prereq_pm version for DateTime should be set, probably something between 1.36 and 1.41.
Download (untitled) / with headers
text/plain 568b
Thank you very much for calling this to my attention. The problem was that I added DateTime-style validation and forgot to update dependencies. Smokers with older versions of DateTime failed while newer ones did not because DateTime's validation recently changed to use Specio. I went with the newer validation scheme, so if the smoker had a recent DateTime my code ran correctly; by accident, as it were. A correction has gone to PAUSE in version 0.900_01. Many thanks for smoking my code, as well as everyone else's, and for taking the time to submit an RT ticket.
Download (untitled) / with headers
text/plain 2.8k
On 2017-03-17 21:48:38, WYANT wrote: Show quoted text
> Thank you very much for calling this to my attention. The problem was > that I added DateTime-style validation and forgot to update > dependencies. Smokers with older versions of DateTime failed while > newer ones did not because DateTime's validation recently changed to > use Specio. I went with the newer validation scheme, so if the smoker > had a recent DateTime my code ran correctly; by accident, as it were. > > A correction has gone to PAUSE in version 0.900_01. > > Many thanks for smoking my code, as well as everyone else's, and for > taking the time to submit an RT ticket.
The current devel version looks better but there are still some fail reports: - with perl 5.8.9 I see syntax errors: # Failed test 'use DateTime::Fiction::JRRTolkien::Shire;' # at t/00load.t line 6. # Tried to use 'DateTime::Fiction::JRRTolkien::Shire'. # Error: Unmatched right curly bracket at /tmpfs/.cpan-build-cpansand/2017031715/DateTime-Fiction-JRRTolkien-Shire-0.900_01-2/blib/lib/DateTime/Fiction/JRRTolkien/Shire/Types.pm line 62, within string # syntax error at /tmpfs/.cpan-build-cpansand/2017031715/DateTime-Fiction-JRRTolkien-Shire-0.900_01-2/blib/lib/DateTime/Fiction/JRRTolkien/Shire/Types.pm line 62, near "}" # Compilation failed in require at /tmpfs/.cpan-build-cpansand/2017031715/DateTime-Fiction-JRRTolkien-Shire-0.900_01-2/blib/lib/DateTime/Fiction/JRRTolkien/Shire/Duration.pm line 10, <DATA> line 1. # BEGIN failed--compilation aborted at /tmpfs/.cpan-build-cpansand/2017031715/DateTime-Fiction-JRRTolkien-Shire-0.900_01-2/blib/lib/DateTime/Fiction/JRRTolkien/Shire/Duration.pm line 10, <DATA> line 1. # Compilation failed in require at /tmpfs/.cpan-build-cpansand/2017031715/DateTime-Fiction-JRRTolkien-Shire-0.900_01-2/blib/lib/DateTime/Fiction/JRRTolkien/Shire.pm line 28, <DATA> line 1. # BEGIN failed--compilation aborted at /tmpfs/.cpan-build-cpansand/2017031715/DateTime-Fiction-JRRTolkien-Shire-0.900_01-2/blib/lib/DateTime/Fiction/JRRTolkien/Shire.pm line 28, <DATA> line 1. # Compilation failed in require at t/00load.t line 6, <DATA> line 1. # BEGIN failed--compilation aborted at t/00load.t line 6, <DATA> line 1. - probably here Params::ValidationCompiler is too old: # Tried to use 'DateTime::Fiction::JRRTolkien::Shire'. # Error: You passed unknown parameters when creating a parameter validator: [name_is_optional] # Compilation failed in require at /home/cpansand/.cpan/build/2017031715/DateTime-Fiction-JRRTolkien-Shire-0.900_01-0/blib/lib/DateTime/Fiction/JRRTolkien/Shire.pm line 28, <DATA> line 1. # BEGIN failed--compilation aborted at /home/cpansand/.cpan/build/2017031715/DateTime-Fiction-JRRTolkien-Shire-0.900_01-0/blib/lib/DateTime/Fiction/JRRTolkien/Shire.pm line 28, <DATA> line 1. # Compilation failed in require at t/00load.t line 6, <DATA> line 1. (on this system Params::ValidationCompiler 0.12 is installed, but name_is_optional was introduced in 0.13)
Download (untitled) / with headers
text/plain 340b
Many thanks again. I really appreciate the feedback, especially now. Version 0.900_02 just went to PAUSE, with dependency versions for Params::ValidationCompiler, DateTime::Duration (currently part of the DateTime distro, but ...) and Date::Tolkien::Shire::Data (yeah, I wrote it, but that's no reason not to recognize dependency versions).
Download (untitled) / with headers
text/plain 551b
On 2017-03-19 09:00:22, WYANT wrote: Show quoted text
> Many thanks again. I really appreciate the feedback, especially now. > Version 0.900_02 just went to PAUSE, with dependency versions for > Params::ValidationCompiler, DateTime::Duration (currently part of the > DateTime distro, but ...) and Date::Tolkien::Shire::Data (yeah, I > wrote it, but that's no reason not to recognize dependency versions).
_02 and _03 look OK (except for 5.8.9, but this is probably another issue): http://fast-matrix.cpantesters.org/?dist=DateTime-Fiction-JRRTolkien-Shire%200.900_02
Download (untitled) / with headers
text/plain 622b
Show quoted text
> > _02 and _03 look OK (except for 5.8.9, but this is probably another > issue): > http://fast-matrix.cpantesters.org/?dist=DateTime-Fiction-JRRTolkien- > Shire%200.900_02
I agree. It looks like either Specio is still wet behind the ears, or I do not have it completely under my control. Or both. At any rate the 5.8.9 problem was easily reproduced, and dealt with by using Specio in a less-efficient but more-deterministic way, as _04. It looks like cpantesters.org may be coming out of its long, dark night-time of the soul. I certainly hope so. And am very (and repeatedly) grateful for you passing your results on.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.