Skip Menu |
 

This queue is for tickets about the IO-Async CPAN distribution.

Report information
The Basics
Id: 120503
Status: new
Priority: 0/
Queue: IO-Async

People
Owner: Nobody in particular
Requestors: chohag [...] jtan.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Incorrect use of maybe_invoke_event in IO::Async::Listener::on_read_ready()
Date: Sat, 04 Mar 2017 21:48:30 +0200
To: bug-IO-Async [...] rt.cpan.org
From: chohag [...] jtan.com
Download (untitled) / with headers
text/plain 447b
This looks like a natural language diff to me... The catch block at the end of on_read_ready() is expected to return a Future but maybe_invoke_event() wraps its arguments up an an arrayref. Replace the last double-line of the catch block with: my $maybe = $self->maybe_invoke_event( on_accept_error => $socket, $dollarbang ); $maybe ? @$maybe : $self->invoke_error( "accept() failed - $dollarbang", accept => $socket, $dollarbang ); Matthew
Subject: Re: [rt.cpan.org #120503] AutoReply: Incorrect use of maybe_invoke_event in IO::Async::Listener::on_read_ready()
Date: Sat, 04 Mar 2017 22:10:35 +0200
To: bug-IO-Async [...] rt.cpan.org
From: chohag [...] jtan.com
Download (untitled) / with headers
text/plain 160b
Further testing suggests that this function is called (all the time?) in scalar context so although @$maybe looks "right", $maybe->[0] actually works. Matthew


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.