This queue is for tickets about the Class-DBI CPAN distribution.

Report information
The Basics
Id:
12047
Status:
resolved
Priority:
Low/Low
Queue:

People
Owner:
Nobody in particular
Requestors:
barbie [...] missbarbell.co.uk
Cc:
AdminCc:

BugTracker
Severity:
Normal
Broken in:
0.96
Fixed in:
3.0.1



Subject: 04-lazy.t test not sorted
Trying to install CDBI I kept getting the SQLite/2 problem. Having finally figure that one out. I kept getting failures in t/04-lazy.t as: t\04-lazy.............NOK 2 # Failed test (t\04-lazy.t at line 20) t\04-lazy.............NOK 3 # Failed test (t\04-lazy.t at line 21) t\04-lazy.............NOK 4 # Failed test (t\04-lazy.t at line 22) t\04-lazy.............NOK 5 # Failed test (t\04-lazy.t at line 23) t\04-lazy.............NOK 6 # Failed test (t\04-lazy.t at line 24) t\04-lazy.............ok 25/25# Looks like you failed 5 tests of 25. t\04-lazy.............dubious Test returned status 5 (wstat 1280, 0x500) DIED. FAILED tests 2-6 Failed 5/25 tests, 80.00% okay The last test was obvious as 'that' actually comes before 'this' ;) However, the others were confusing. I changed the ok(eq_set()) sequences to is_deeply() and they now all pass. I'm not entirely sure whether this is significant or not, but thought it better to note the problem here than not :)
--- C:\wip\diffs\Class-DBI\Class-DBI-0.96/t/04-lazy.t Sun Apr 25 17:33:36 2004 +++ C:\wip\diffs\Class-DBI\Class-DBI-0.96-barbie/t/04-lazy.t Tue Mar 29 12:44:50 2005 @@ -16,12 +16,12 @@ Lazy->CONSTRUCT; } -ok(eq_set([ Lazy->columns('Primary') ], [qw/this/]), "Pri"); -ok(eq_set([ sort Lazy->columns('Essential') ], [qw/opop this/]), "Essential"); -ok(eq_set([ sort Lazy->columns('things') ], [qw/that this/]), "things"); -ok(eq_set([ sort Lazy->columns('horizon') ], [qw/eep orp/]), "horizon"); -ok(eq_set([ sort Lazy->columns('vertical') ], [qw/oop opop/]), "vertical"); -ok(eq_set([ sort Lazy->columns('All') ], [qw/eep oop opop orp this that/]), +is_deeply([ Lazy->columns('Primary') ], [qw/this/], "Pri"); +is_deeply([ sort Lazy->columns('Essential') ], [qw/opop this/], "Essential"); +is_deeply([ sort Lazy->columns('things') ], [qw/that this/], "things"); +is_deeply([ sort Lazy->columns('horizon') ], [qw/eep orp/], "horizon"); +is_deeply([ sort Lazy->columns('vertical') ], [qw/oop opop/], "vertical"); +is_deeply([ sort Lazy->columns('All') ], [qw/eep oop opop orp that this/], "All"); {
Date: Wed, 30 Mar 2005 09:39:22 +0100
From: Tony Bowden <tony@kasei.com>
To: via RT <bug-Class-DBI@rt.cpan.org>
CC: undisclosed-recipients: ;
Subject: Re: [cpan #12047] 04-lazy.t test not sorted
RT-Send-Cc:
On Tue, Mar 29, 2005 at 07:05:56AM -0500, via RT wrote:
Show quoted text
> However, the others were confusing. I changed the ok(eq_set()) sequences > to is_deeply() and they now all pass. I'm not entirely sure whether this > is significant or not, but thought it better to note the problem here > than not :)
Weird. I should probably change them to is_deeply anyway, but I'm rather confused by this ... Tony
[tony@kasei.com - Wed Mar 30 03:46:10 2005]:
Show quoted text
> Weird. I should probably change them to is_deeply anyway, but I'm rather > confused by this ...
See bugs.perl.org 36354 for a probable explaination.
From: trevor.schellhorn-perl@marketingtips.com
[tony@kasei.com - Wed Mar 30 03:46:10 2005]:
Show quoted text
> On Tue, Mar 29, 2005 at 07:05:56AM -0500, via RT wrote:
> > However, the others were confusing. I changed the ok(eq_set())
> sequences
> > to is_deeply() and they now all pass. I'm not entirely sure whether
> this
> > is significant or not, but thought it better to note the problem
> here
> > than not :)
> > Weird. I should probably change them to is_deeply anyway, but I'm > rather > confused by this ... > > Tony > >
Also, the 'expected' for the test is not sorted properly. 'that' comes before 'this'. Changing the order of the 'expected' does not make the test pass. Changing to 'is_deeply' makes it work though. I only changed the one test that was failing though. Hope this helps. Trevor


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.