Skip Menu |
 

This queue is for tickets about the Compress-Raw-Zlib CPAN distribution.

Report information
The Basics
Id: 120207
Status: resolved
Priority: 0/
Queue: Compress-Raw-Zlib

People
Owner: Nobody in particular
Requestors: jhi [...] iki.fi
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 2.071
Fixed in: 2.072



Subject: inflateUndermine: subvert arg conditionally used/unused
Download (untitled) / with headers
text/plain 795b
Sorry, it seems that this spot has been patched several times, due to fighting requirements. In 2.069 the line with state->sane = !subvert; was unused just below the #ifdef line due to https://rt.cpan.org/Public/Bug/Display.html?id=105414 because if both that line and the later state->sane = 1; are to be executed, the !subvert line has no effect and is redundant. In 2.070 the line was moved back above the #ifdef, due to https://rt.cpan.org/Public/Bug/Display.html?id=107642 because compilers were warning about the unused subvert argument. This undid the change in 2.069. (In 2.071 there was no change to this spot.) My suggested patch (attached) moves the !subvert line back inside the #ifdef, but adds (void)subvert; (the usual way to deal with unused args) to the #else branch.
Subject: zlib.pat
Download zlib.pat
application/octet-stream 534b

Message body not shown because it is not plain text.

Download (untitled) / with headers
text/plain 355b
Thanks, your patch matches exactly what upstream zlib does, so I have no issue applying it. At some point soon(ish), I will update this module to ship the zlib 1.2.11 sources, so I hope we don't end up revisiting all these changes again! Think upstream zlib has gone already got all the Coverity changes, so finger crossed there isn't anything new. Paul
From: jhi [...] iki.fi
Download (untitled) / with headers
text/plain 528b
On Sat Feb 11 13:00:19 2017, PMQS wrote: Show quoted text
> Thanks, your patch matches exactly what upstream zlib does, so I have > no issue applying it. > > At some point soon(ish), I will update this module to ship the zlib > 1.2.11 sources, so I hope we don't end up revisiting all these changes > again! Think upstream zlib has gone already got all the Coverity > changes, so finger crossed there isn't anything new. > > Paul
The final deadline for 5.26 changes is coming next week. Ask Sawyer X <xsawyerx@cpan.org> about the details.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.