Skip Menu |
 

This queue is for tickets about the SQL-Statement CPAN distribution.

Report information
The Basics
Id: 120163
Status: open
Priority: 0/
Queue: SQL-Statement

People
Owner: Nobody in particular
Requestors: jleu [...] mindspring.com
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 1.410
Fixed in: (no value)



Subject: Support OR in JOIN clause - patch
Download (untitled) / with headers
text/plain 242b
I'm including a patch that has two changes: - Add support for LIMIT d OFFSET d - Add support for OR in JOIN clause - this required addition of < > to term split - required stripping of ()'s from ids Please email me with any questions
Subject: diff
Download diff
application/octet-stream 1.9k

Message body not shown because it is not plain text.

Subject: Re: [rt.cpan.org #120163] Support OR in JOIN clause - patch
Date: Thu, 9 Feb 2017 23:21:10 +0100
To: bug-SQL-Statement [...] rt.cpan.org
From: Jens Rehsack <rehsack [...] gmail.com>
Show quoted text
> Am 09.02.2017 um 23:06 schrieb jleu@mindspring.com via RT <bug-SQL-Statement@rt.cpan.org>: > > Thu Feb 09 17:06:33 2017: Request 120163 was acted upon. > Transaction: Ticket created by jleu@mindspring.com > Queue: SQL-Statement > Subject: Support OR in JOIN clause - patch > Broken in: 1.410 > Severity: Wishlist > Owner: Nobody > Requestors: jleu@mindspring.com > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=120163 > > > > I'm including a patch that has two changes: > - Add support for LIMIT d OFFSET d > - Add support for OR in JOIN clause > - this required addition of < > to term split > - required stripping of ()'s from ids > > Please email me with any questions > <diff>
I didn't review the patch at all, but I miss definitively some tests proving that it works and ensure future patches don't add new regressions. Would you please so kind and add some? I expect that no of existing tests fail with that patch. I will surely prove, but for now - expecting everything is fine :) Cheers -- Jens Rehsack - rehsack@gmail.com
Download signature.asc
application/pgp-signature 842b

Message body not shown because it is not plain text.

Subject: Re: [rt.cpan.org #120163] Support OR in JOIN clause - patch
Date: Thu, 9 Feb 2017 16:25:02 -0600
To: bug-SQL-Statement [...] rt.cpan.org
From: "James R. Leu" <jleu [...] mindspring.com>
Download (untitled) / with headers
text/plain 1.3k
Sorry, I was thinking small :-) I will create some test cases and submit an updated patch On Feb 9, 2017 16:21, "Jens Rehsack via RT" <bug-SQL-Statement@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=120163 > > >
> > Am 09.02.2017 um 23:06 schrieb jleu@mindspring.com via RT <
> bug-SQL-Statement@rt.cpan.org>:
> > > > Thu Feb 09 17:06:33 2017: Request 120163 was acted upon. > > Transaction: Ticket created by jleu@mindspring.com > > Queue: SQL-Statement > > Subject: Support OR in JOIN clause - patch > > Broken in: 1.410 > > Severity: Wishlist > > Owner: Nobody > > Requestors: jleu@mindspring.com > > Status: new > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=120163 > > > > > > > I'm including a patch that has two changes: > > - Add support for LIMIT d OFFSET d > > - Add support for OR in JOIN clause > > - this required addition of < > to term split > > - required stripping of ()'s from ids > > > > Please email me with any questions > > <diff>
> > I didn't review the patch at all, but I miss definitively some tests > proving that it works and ensure future patches don't add new regressions. > Would you please so kind and add some? > > I expect that no of existing tests fail with that patch. I will surely > prove, but for now - expecting everything is fine :) > > Cheers > -- > Jens Rehsack - rehsack@gmail.com > > >
Subject: Re: [rt.cpan.org #120163] Support OR in JOIN clause - patch
Date: Thu, 9 Feb 2017 23:28:55 +0100
To: bug-SQL-Statement [...] rt.cpan.org
From: Jens Rehsack <rehsack [...] gmail.com>
Download (untitled) / with headers
text/plain 1.9k
Show quoted text
> Am 09.02.2017 um 23:25 schrieb jleu@mindspring.com via RT <bug-SQL-Statement@rt.cpan.org>: > > Queue: SQL-Statement > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=120163 > > > Sorry, I was thinking small :-)
Do lot's of tiny patches create an impressive result. No worries :) Please also try some combinations (ON foo AND bar OR baz) and stacks (foo AND bar OR fom AND baz) Show quoted text
> I will create some test cases and submit an updated patch
You can also submit pull-requests on Github which will lead to Travis will run all tests against your patches. Cheers, Jens Show quoted text
> On Feb 9, 2017 16:21, "Jens Rehsack via RT" <bug-SQL-Statement@rt.cpan.org> > wrote: >
>> <URL: https://rt.cpan.org/Ticket/Display.html?id=120163 > >> >>
>>> Am 09.02.2017 um 23:06 schrieb jleu@mindspring.com via RT <
>> bug-SQL-Statement@rt.cpan.org>:
>>> >>> Thu Feb 09 17:06:33 2017: Request 120163 was acted upon. >>> Transaction: Ticket created by jleu@mindspring.com >>> Queue: SQL-Statement >>> Subject: Support OR in JOIN clause - patch >>> Broken in: 1.410 >>> Severity: Wishlist >>> Owner: Nobody >>> Requestors: jleu@mindspring.com >>> Status: new >>> Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=120163 > >>> >>> >>> I'm including a patch that has two changes: >>> - Add support for LIMIT d OFFSET d >>> - Add support for OR in JOIN clause >>> - this required addition of < > to term split >>> - required stripping of ()'s from ids >>> >>> Please email me with any questions >>> <diff>
>> >> I didn't review the patch at all, but I miss definitively some tests >> proving that it works and ensure future patches don't add new regressions. >> Would you please so kind and add some? >> >> I expect that no of existing tests fail with that patch. I will surely >> prove, but for now - expecting everything is fine :) >> >> Cheers >> -- >> Jens Rehsack - rehsack@gmail.com >> >> >>
-- Jens Rehsack - rehsack@gmail.com
Download signature.asc
application/pgp-signature 842b

Message body not shown because it is not plain text.



This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.