Skip Menu |
 

This queue is for tickets about the Net-SIP CPAN distribution.

Report information
The Basics
Id: 120011
Status: resolved
Priority: 0/
Queue: Net-SIP

People
Owner: Nobody in particular
Requestors: richard.carver [...] cloudmont.co.uk
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Undefined value in Net::SIP::Leg forward_outgoing
Date: Fri, 27 Jan 2017 16:59:25 +0000
To: "bug-Net-SIP [...] rt.cpan.org" <bug-Net-SIP [...] rt.cpan.org>
From: Richard Carver <richard.carver [...] cloudmont.co.uk>
Download (untitled) / with headers
text/plain 529b
If the SIP client does not specify a branch in the Via header then perl warns of an undefined value in forward_outgoing: if (substr( $param->{branch},0,length($branch) ) eq $branch ) { Changing it to this removes the warning and seems to be the correct thing to do since the code is checking whether this leg is already in the Via headers and we always add a branch, so any via headers with no branch are not relevant to this check: if ( exists $param->{branch} and substr( $param->{branch},0,length($branch) ) eq $branch ) {
Download (untitled) / with headers
text/plain 335b
Am Fr 27. Jan 2017, 12:32:33, richard.carver@cloudmont.co.uk schrieb: Show quoted text
> If the SIP client does not specify a branch in the Via header then > ...
According to RFC 3261 section 8.1.1.7 a Via header must contain a branch, so this should not happen in theory. Since theory often differs from practice I've added a check in commit ce257ff.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.