Skip Menu |
 

This queue is for tickets about the Net-STOMP-Client CPAN distribution.

Report information
The Basics
Id: 119869
Status: resolved
Priority: 0/
Queue: Net-STOMP-Client

People
Owner: LCONS [...] cpan.org
Requestors: TJC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 2.2
Fixed in: 2.3



Subject: failover regex does not match domain names including underscore character
Download (untitled) / with headers
text/plain 153b
In Net-STOMP-Client-Connection.pm, the regex used to match failover()-type URIs will fail to match if the domain name includes an underscore character.
Download (untitled) / with headers
text/plain 266b
Net-STOMP-Client complies to RFC-952 that specifies that: A "name" (Net, Host, Gateway, or Domain name) is a text string up to 24 characters drawn from the alphabet (A-Z), digits (0-9), minus sign (-), and period (.). Underscores should not appear in domain names.
Download (untitled) / with headers
text/plain 369b
Back when the original standard was built, sure, but I've seen plenty of underscores turn up in domain names in recent years -- even as subdomains off google's base domain name. Essentially -- it'd be good if Net-STOMP-Client was flexible and didn't try and enforce that standard. How's the saying go? "Be conservative in what you send, be liberal in what you accept"
Download (untitled) / with headers
text/plain 147b
See also the URI specification, which would seem to be the more correct spec to apply to the MQ URIs: https://tools.ietf.org/html/rfc3986#section-2
Fair enough. I've modified the sources so the next released version will allow underscores.
Thanks, I appreciate your understanding.
Fixed in the newly released 2.3.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.