Skip Menu |
 

This queue is for tickets about the Badger CPAN distribution.

Report information
The Basics
Id: 119422
Status: open
Priority: 0/
Queue: Badger

People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in:
  • 0.12
  • 0.13
Fixed in: (no value)

Attachments


Subject: [PATCH] kwalitee.t fails when Test::Pod is installed and AUTOMATED_TESTING=1
Download (untitled) / with headers
text/plain 281b
As per subject. Sample fail report: http://www.cpantesters.org/cpan/report/76032937 I've verified manually. Patch appended. But even better than this patch would be to make kwalitee an author-only test, failing pod tests make enduser installs fail unnecessarily. HTH&&Thanks,
Subject: Badger-0.12-encoding-on-pod.diff
--- ../Badger-0.12-1/lib/Badger/Hub.pm 2016-12-12 16:11:33.000000000 +0000 +++ lib/Badger/Hub.pm 2016-12-23 19:42:07.843298792 +0000 @@ -409,6 +409,8 @@ 1; __END__ +=encoding utf8 + =head1 NAME Badger::Hub - central repository of shared resources --- ../Badger-0.12-1/lib/Badger/Filesystem.pm 2016-12-12 16:11:33.000000000 +0000 +++ lib/Badger/Filesystem.pm 2016-12-23 19:42:27.747188992 +0000 @@ -724,6 +724,8 @@ __END__ +=encoding utf8 + =head1 NAME Badger::Filesystem - filesystem functionality --- ../Badger-0.12-1/lib/Badger/Filesystem/Path.pm 2016-12-12 16:11:33.000000000 +0000 +++ lib/Badger/Filesystem/Path.pm 2016-12-23 19:43:31.954834804 +0000 @@ -392,6 +392,8 @@ 1; +=encoding utf8 + =head1 NAME Badger::Filesystem::Path - generic fileystem path object
Download (untitled) / with headers
text/plain 968b
On 2016-12-23 11:56:23, ANDK wrote: Show quoted text
> As per subject. Sample fail report: > > http://www.cpantesters.org/cpan/report/76032937 > > I've verified manually. Patch appended. > > But even better than this patch would be to make kwalitee an author- > only test, failing pod tests make enduser installs fail unnecessarily.
As ANDK said, while this test failure is indeed an issue that should be corrected, please don't allow pod, critic, coverage or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which can be predicted in advance. Either move these tests to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.