Skip Menu |
 

This queue is for tickets about the Catalyst-Runtime CPAN distribution.

Report information
The Basics
Id: 119293
Status: resolved
Priority: 0/
Queue: Catalyst-Runtime

People
Owner: Nobody in particular
Requestors: jegade [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 5.90113
Fixed in: 5.90112



Subject: Double dots in request paths results in process stall
Download (untitled) / with headers
text/plain 230b
If the request path contains two dots, like /double/demo..ext, the process which handle the request stuck. These begins with 5.90113, 5.90112 handle this correct. Maybe this is related to the changes for relative action methods.
Subject: double-dot-path.t
Download double-dot-path.t
text/x-perl 636b
use Test::Most; { package MyApp::Controller::Root; $INC{'MyApp/Controller/Root.pm'} = __FILE__; use Moose; use MooseX::MethodAttributes; extends 'Catalyst::Controller'; __PACKAGE__->config->{namespace} = ''; sub default : Path { my ( $self, $c ) = @_; $c->response->status(200); $c->response->body("Ok"); } __PACKAGE__->meta->make_immutable; package MyApp; $INC{'MyApp.pm'} = __FILE__; use Catalyst; MyApp->setup; } use Catalyst::Test 'MyApp'; ok request '/'; ok request '/double/dot.ext'; ok request '/double/dot..ext'; done_testing();
Subject: double-dot-test.patch
diff --git a/t/double-dot-path.t b/t/double-dot-path.t new file mode 100644 index 0000000..cd6156c --- /dev/null +++ b/t/double-dot-path.t @@ -0,0 +1,39 @@ +use Test::Most; + +{ + package MyApp::Controller::Root; + $INC{'MyApp/Controller/Root.pm'} = __FILE__; + + use Moose; + use MooseX::MethodAttributes; + + extends 'Catalyst::Controller'; + + __PACKAGE__->config->{namespace} = ''; + + sub default : Path { + + my ( $self, $c ) = @_; + + $c->response->status(200); + $c->response->body("Ok"); + } + + __PACKAGE__->meta->make_immutable; + + package MyApp; + $INC{'MyApp.pm'} = __FILE__; + + use Catalyst; + + MyApp->setup; +} + +use Catalyst::Test 'MyApp'; + +ok request '/'; +ok request '/double/dot.ext'; +ok request '/double/dot..ext'; + +done_testing(); +
Download (untitled) / with headers
text/plain 382b
On Sun Dec 18 15:20:28 2016, JEGADE wrote: Show quoted text
> If the request path contains two dots, like /double/demo..ext, the > process which handle the request stuck. These begins with 5.90113, > 5.90112 handle this correct. Maybe this is related to the changes for > relative action methods.
This should be fixed, at least it says so in the change log. Feel free to reopen ticket if its not


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.