Skip Menu |
 

This queue is for tickets about the bignum CPAN distribution.

Report information
The Basics
Id: 119225
Status: resolved
Priority: 0/
Queue: bignum

People
Owner: Nobody in particular
Requestors: nanis [...] cpan.org
Cc: DBOOK [...] cpan.org
ether [...] cpan.org
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.47



Subject: Please fix Makefile.PL so it doesn't install over core version
Date: Tue, 13 Dec 2016 09:07:25 -0500
To: bug-bignum [...] rt.cpan.org
From: "A. Sinan Unur" <nanis [...] cpan.org>
Download (untitled) / with headers
text/plain 242b
perls since 5.12 look in site/lib first, therefore the upgrade has no effect. See also https://www.nntp.perl.org/group/perl.perl5.porters/2016/12/msg241637.html and https://twitter.com/sinan_unur/status/808650748334587905 HTH, -- Sinan
Subject: Re: [rt.cpan.org #119225] AutoReply: Please fix Makefile.PL so it doesn't install over core version
Date: Tue, 13 Dec 2016 09:16:27 -0500
To: bug-bignum [...] rt.cpan.org
From: "A. Sinan Unur" <nanis [...] cpan.org>
Download (untitled) / with headers
text/plain 341b
This should be considered a critical bug because, with perl version >= 5.12, subsequent upgrades will have no effect if user ever upgraded bignum and friends since installing perl. Anyone who installed 0.46 lost the ability to revert to the version that came with the original distribution simply by removing files from site/lib. -- Sinan
Subject: Re: [rt.cpan.org #119225] AutoReply: Please fix Makefile.PL so it doesn't install over core version
Date: Tue, 13 Dec 2016 09:17:40 -0500
To: bug-bignum [...] rt.cpan.org
From: "A. Sinan Unur" <nanis [...] cpan.org>
Download (untitled) / with headers
text/plain 178b
Of course, the same fix should also be applied to Makefile.PL in Math::BigInt Math::BigInt::FastCalc Math::BigRat I am not going to file extra bug reports for those. -- Sinan
Download (untitled) / with headers
text/plain 615b
The correct fix for this is to include logic such as other dual life modules have, such that INSTALLDIRS is 'perl' only after the module became core and before 5.012: https://metacpan.org/source/EXODIST/Test-Simple-1.302067/Makefile.PL#L53-54 https://metacpan.org/source/JPEACOCK/version-0.9917/Makefile.PL#L63-65 For bignum and Math::BigRat, INSTALLDIRS should be 'perl' if ($] >= 5.008 and $] < 5.012). For Math::BigInt::FastCalc, INSTALLDIRS should be 'perl' if ($] >= 5.009003 and $] < 5.012). For Math::BigInt, INSTALLDIRS should be 'perl' if ($] < 5.012). In all other cases, it should be 'site' or omitted.
Download (untitled) / with headers
text/plain 159b
I thought the first suggsted fix in CPAN RT #119199 would do the trick. I wasn't aware of the distiction < 5.12 vs. >= 5.12. I am working on a new release now.
Download (untitled) / with headers
text/plain 193b
I have now uploaded the following files to CPAN. Hopefully, it is correct this time. bignum-0.47.tar.gz Math-BigInt-1.999806.tar.gz Math-BigInt-FastCalc-0.5005.tar.gz Math-BigRat-0.2611.tar.gz
CC: DBOOK [...] cpan.org, ether [...] cpan.org
Subject: Re: [rt.cpan.org #119225] Please fix Makefile.PL so it doesn't install over core version
Date: Tue, 13 Dec 2016 17:17:15 -0500
To: bug-bignum [...] rt.cpan.org
From: "A. Sinan Unur" <nanis [...] cpan.org>
Download (untitled) / with headers
text/plain 1.5k
On Tue, Dec 13, 2016 at 4:13 PM, Peter John Acklam via RT <bug-bignum@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=119225 > > > I have now uploaded the following files to CPAN. Hopefully, it is correct this time.
Seems to be OK on Windows with perl 5.24.1 RC4 C:\> cpan-outdated|cpanm --> Working on P/PJ/PJACKLAM/bignum-0.47.tar.gz Fetching https://cpan.metacpan.org/authors/id/P/PJ/PJACKLAM/bignum-0.47.tar.gz ... OK Configuring bignum-0.47 ... OK Building and testing bignum-0.47 ... OK Successfully installed bignum-0.47 --> Working on P/PJ/PJACKLAM/Math-BigInt-1.999806.tar.gz Fetching https://cpan.metacpan.org/authors/id/P/PJ/PJACKLAM/Math-BigInt-1.999806.tar.gz ... OK Configuring Math-BigInt-1.999806 ... OK Building and testing Math-BigInt-1.999806 ... OK Successfully installed Math-BigInt-1.999806 --> Working on P/PJ/PJACKLAM/Math-BigInt-FastCalc-0.5005.tar.gz Fetching https://cpan.metacpan.org/authors/id/P/PJ/PJACKLAM/Math-BigInt-FastCalc-0.5005.tar.gz ... OK Configuring Math-BigInt-FastCalc-0.5005 ... OK Building and testing Math-BigInt-FastCalc-0.5005 ... OK Successfully installed Math-BigInt-FastCalc-0.5005 --> Working on P/PJ/PJACKLAM/Math-BigRat-0.2611.tar.gz Fetching https://cpan.metacpan.org/authors/id/P/PJ/PJACKLAM/Math-BigRat-0.2611.tar.gz ... OK Configuring Math-BigRat-0.2611 ... OK Building and testing Math-BigRat-0.2611 ... OK Successfully installed Math-BigRat-0.2611 4 distributions installed C:\> perl -Mbignum -E "say $bignum::VERSION" 0.47 C:\> cpan-outdated --verbose C:\Users\sinan>
Subject: Re: [rt.cpan.org #119225] Please fix Makefile.PL so it doesn't install over core version
Date: Tue, 13 Dec 2016 17:17:45 -0500
To: bug-bignum [...] rt.cpan.org
From: "A. Sinan Unur" <nanis [...] cpan.org>
Download (untitled) / with headers
text/plain 304b
On Tue, Dec 13, 2016 at 4:13 PM, Peter John Acklam via RT <bug-bignum@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=119225 > > > I have now uploaded the following files to CPAN. Hopefully, it is correct this time.
Thank you very much for your work and quick response. -- Sinan


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.