Skip Menu |
 

This queue is for tickets about the Compress-Raw-Zlib CPAN distribution.

Report information
The Basics
Id: 119007
Status: resolved
Priority: 0/
Queue: Compress-Raw-Zlib

People
Owner: Nobody in particular
Requestors: RURBAN [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 2.070

Attachments
0001-Compress-Raw-Zlib-fix-APPEND-logic.patch



Subject: [PATCH] Wrong FLAG_APPEND logic analog to Bzip2
Download (untitled) / with headers
text/plain 104b
clang-4 detected that if(! s->flags & FLAG_APPEND) is wrong. ! binds stronger than &. -- Reini Urban
Subject: 0001-Compress-Raw-Zlib-fix-APPEND-logic.patch
From e0a3af41f943e4cd27864461e9e12ab934b974f1 Mon Sep 17 00:00:00 2001 From: Reini Urban <rurban@cpanel.net> Date: Sun, 27 Nov 2016 23:26:55 +0100 Subject: [PATCH] Compress-Raw-Zlib: fix APPEND logic analog to Bzip2.xs clang-4 detected that if(! s->flags & FLAG_APPEND) is wrong. ! binds stronger than &. --- cpan/Compress-Raw-Zlib/Zlib.xs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git cpan/Compress-Raw-Zlib/Zlib.xs cpan/Compress-Raw-Zlib/Zlib.xs index 664c26c..ad20381 100644 --- cpan/Compress-Raw-Zlib/Zlib.xs +++ cpan/Compress-Raw-Zlib/Zlib.xs @@ -1088,7 +1088,7 @@ flush(s, output, f=Z_FINISH) if (DO_UTF8(output) && !sv_utf8_downgrade(output, 1)) croak("Wide character in Compress::Raw::Zlib::Deflate::flush input parameter"); #endif - if(! s->flags & FLAG_APPEND) { + if(!(s->flags & FLAG_APPEND)) { SvCUR_set(output, 0); /* sv_setpvn(output, "", 0); */ } -- 2.10.2
Download (untitled) / with headers
text/plain 198b
On Sun Nov 27 17:29:39 2016, RURBAN wrote: Show quoted text
> clang-4 detected that if(! s->flags & FLAG_APPEND) is wrong. > ! binds stronger than &. > >
And this one has been wrong for even longer. Fixed Paul


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.