Skip Menu |
 

This queue is for tickets about the Google-Ads-AdWords-Client CPAN distribution.

Report information
The Basics
Id: 118509
Status: open
Priority: 0/
Queue: Google-Ads-AdWords-Client

People
Owner: Nobody in particular
Requestors: KENTNL [...] cpan.org
SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in:
  • 4.11.0
  • 4.12.0
  • 4.15.0
Fixed in: (no value)

Attachments
0003-Fix-unescaped-error-in-tests-t-022-and-t-024.patch



Subject: Unescaped left brace in regex is illegal here in regex
Download (untitled) / with headers
text/plain 715b
With newer perls (e.g. 5.25.6) the test suite fails: Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/ReportDownloadError\s{ <-- HERE [^}]+}/ at t/022_ReportUtils.t line 60. # Looks like your test exited with 255 before it could output anything. t/022_ReportUtils.t ................... Dubious, test returned 255 (wstat 65280, 0xff00) Failed 28/28 subtests ... Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/BatchJobHandlerError\s{ <-- HERE [^}]+}/ at t/024_BatchJobHandler.t line 136. # Looks like your test exited with 255 before it could output anything. t/024_BatchJobHandler.t ............... Dubious, test returned 255 (wstat 65280, 0xff00)
Download (untitled) / with headers
text/plain 869b
On 2016-10-26 02:52:19, SREZIC wrote: Show quoted text
> With newer perls (e.g. 5.25.6) the test suite fails: > > Unescaped left brace in regex is illegal here in regex; marked by <-- > HERE in m/ReportDownloadError\s{ <-- HERE [^}]+}/ at > t/022_ReportUtils.t line 60. > # Looks like your test exited with 255 before it could output > anything. > t/022_ReportUtils.t ................... > Dubious, test returned 255 (wstat 65280, 0xff00) > Failed 28/28 subtests > ... > Unescaped left brace in regex is illegal here in regex; marked by <-- > HERE in m/BatchJobHandlerError\s{ <-- HERE [^}]+}/ at > t/024_BatchJobHandler.t line 136. > # Looks like your test exited with 255 before it could output > anything. > t/024_BatchJobHandler.t ............... > Dubious, test returned 255 (wstat 65280, 0xff00)
Problem happens also with 4.12.0 (checked with the current bleadperl 5.25.10).
On 2017-02-28 16:53:52, SREZIC wrote: Show quoted text
> On 2016-10-26 02:52:19, SREZIC wrote:
> > With newer perls (e.g. 5.25.6) the test suite fails: > > > > Unescaped left brace in regex is illegal here in regex; marked by <-- > > HERE in m/ReportDownloadError\s{ <-- HERE [^}]+}/ at > > t/022_ReportUtils.t line 60. > > # Looks like your test exited with 255 before it could output > > anything. > > t/022_ReportUtils.t ................... > > Dubious, test returned 255 (wstat 65280, 0xff00) > > Failed 28/28 subtests > > ... > > Unescaped left brace in regex is illegal here in regex; marked by <-- > > HERE in m/BatchJobHandlerError\s{ <-- HERE [^}]+}/ at > > t/024_BatchJobHandler.t line 136. > > # Looks like your test exited with 255 before it could output > > anything. > > t/024_BatchJobHandler.t ............... > > Dubious, test returned 255 (wstat 65280, 0xff00)
> > Problem happens also with 4.12.0 (checked with the current bleadperl > 5.25.10).
And with 4.13.0 Please note that the next stable perl will be released in a few weeks.
Download (untitled) / with headers
text/plain 1.1k
On 2017-03-16 16:12:06, SREZIC wrote: Show quoted text
> On 2017-02-28 16:53:52, SREZIC wrote:
> > On 2016-10-26 02:52:19, SREZIC wrote:
> > > With newer perls (e.g. 5.25.6) the test suite fails: > > > > > > Unescaped left brace in regex is illegal here in regex; marked by <-- > > > HERE in m/ReportDownloadError\s{ <-- HERE [^}]+}/ at > > > t/022_ReportUtils.t line 60. > > > # Looks like your test exited with 255 before it could output > > > anything. > > > t/022_ReportUtils.t ................... > > > Dubious, test returned 255 (wstat 65280, 0xff00) > > > Failed 28/28 subtests > > > ... > > > Unescaped left brace in regex is illegal here in regex; marked by <-- > > > HERE in m/BatchJobHandlerError\s{ <-- HERE [^}]+}/ at > > > t/024_BatchJobHandler.t line 136. > > > # Looks like your test exited with 255 before it could output > > > anything. > > > t/024_BatchJobHandler.t ............... > > > Dubious, test returned 255 (wstat 65280, 0xff00)
> > > > Problem happens also with 4.12.0 (checked with the current bleadperl > > 5.25.10).
> > And with 4.13.0 > Please note that the next stable perl will be released in a few weeks. >
Fails also with 4.14.0. And perl 5.26.0 was released today.
Fixing this should be easy. Patch attached.

-- 
- CPAN kentnl@cpan.org
- Gentoo Perl Maintainer kentnl@gentoo.org ( perl@gentoo.org )
Subject: 0003-Fix-unescaped-error-in-tests-t-022-and-t-024.patch
From a7e92591ac0415fbb7119e4ad7572f910e4fdb8f Mon Sep 17 00:00:00 2001 From: Kent Fredric <kentfredric@gmail.com> Date: Sun, 4 Jun 2017 07:43:59 +1200 Subject: [PATCH 3/3] Fix unescaped "{" error in tests t/022* and t/024* Perl 5.26 makes use of literal unescaped { in a regex illegal, and this leads to test failures. This change simply quotes the offending characters to make tests pass. This closes RT#118509 Bug: https://rt.cpan.org/Ticket/Display.html?id=118509 --- t/022_ReportUtils.t | 2 +- t/024_BatchJobHandler.t | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/t/022_ReportUtils.t b/t/022_ReportUtils.t index 4f5f326..d0e2000 100755 --- a/t/022_ReportUtils.t +++ b/t/022_ReportUtils.t @@ -57,7 +57,7 @@ my $report_as_string = $report_handler->get_as_string(); ok(!$report_as_string, "report as string"); ok($report_as_string->isa("Google::Ads::Common::ReportDownloadError"), "check report handler->report_as_string return type"); -ok($report_as_string =~ /ReportDownloadError\s{[^}]+}/, +ok($report_as_string =~ /ReportDownloadError\s\{[^}]+}/, "check ReportDownloadError STRINGIFY"); my ($fh, $filename) = tempfile(); diff --git a/t/024_BatchJobHandler.t b/t/024_BatchJobHandler.t index 15983ae..4b86703 100755 --- a/t/024_BatchJobHandler.t +++ b/t/024_BatchJobHandler.t @@ -133,6 +133,6 @@ my $batch_job_handler_error = description => "test" }); ok(!$batch_job_handler_error, "BOOLIFY on error false"); -ok($batch_job_handler_error =~ /BatchJobHandlerError\s{[^}]+}/, +ok($batch_job_handler_error =~ /BatchJobHandlerError\s\{[^}]+}/, "check BatchJobHandlerError STRINGIFY"); -- 2.12.2


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.