Skip Menu |
 

This queue is for tickets about the Hijk CPAN distribution.

Report information
The Basics
Id: 118425
Status: resolved
Priority: 0/
Queue: Hijk

People
Owner: GUGOD [...] cpan.org
Requestors: develop [...] traveljury.com
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.26
Fixed in: (no value)



Subject: Headers should be case-insensitive
Download (untitled) / with headers
text/plain 343b
Headers are checked case-sensitively here https://metacpan.org/source/AVAR/Hijk-0.26/lib/Hijk.pm#L86 According to https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2 "Field names are case-insensitive." This code breaks in Elasticsearch 5.0 which now returns lowercase headers, and a request from Hijk just hangs until it times out.
Download (untitled) / with headers
text/plain 666b
在 2016-十月-18 14:28:35 星期二 時,DRTECH 寫到: Show quoted text
> Headers are checked case-sensitively here > https://metacpan.org/source/AVAR/Hijk-0.26/lib/Hijk.pm#L86 According > to https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2 > "Field names are case-insensitive." > > This code breaks in Elasticsearch 5.0 which now returns lowercase > headers, and a request from Hijk just hangs until it times out.
Thanks for the nice info Clinton, A patch is pushed to address this issue, https://github.com/gugod/Hijk/commit/2d410c3f0fa5b4bb568dd3fe15f72ffb2c9027c1 I don't expect it breaks any existing stuff, but I'll briefly test it and release it.
Download (untitled) / with headers
text/plain 464b
在 2016-十月-27 16:16:48 星期四 時,GUGOD 寫到: Show quoted text
> A patch is pushed to address this issue, > https://github.com/gugod/Hijk/commit/2d410c3f0fa5b4bb568dd3fe15f72ffb2c9027c1 > > I don't expect it breaks any existing stuff, but I'll briefly test it > and release it.
Hijk 0.27 was just released with only this change. I briefly tested with Elasticsearch 5.0 and that looks OK. If it all looks OK on your side as well feel free to close this ticket :)
Thanks gugod - looks good to me closing


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.