Skip Menu |
 

This queue is for tickets about the CSS CPAN distribution.

Report information
The Basics
Id: 11788
Status: open
Priority: 0/
Queue: CSS

People
Owner: Nobody in particular
Requestors: jammin [...] qolc.net
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in:
  • 1.07
  • 1.08
Fixed in: (no value)

Attachments
multi-line-comments.patch



Subject: CSS.pm doesn't ignore multi-line comments
Download (untitled) / with headers
text/plain 306b
CSS.pm cannot cope with comments that span more than one line like this: /* This is a totally valid CSS comment */ They don't get removed before being passed onto the parser, resulting in a royal mess. The test suite only contains one-line comments. The fix is easy and I've attached a patch.
--- CSS.pm.orig Tue Mar 23 20:13:01 2004 +++ CSS.pm Mon Mar 7 09:32:15 2005 @@ -66,7 +66,7 @@ my $string = shift; # remove comments - $string =~ s!/\*.*?\*\/!!g; + $string =~ s!/\*.*?\*\/!!gs; $string =~ s|<!--||g; $string =~ s|-->||g;
Adding a "me too" on this.
RT-Send-CC: srezic [...] iconmobile.com
Download (untitled) / with headers
text/plain 200b
Maybe related: if the multi-line comment contains a curly brace like this: /* { */ then the parsing completely fails with an error message "Invalid or unexpected property ...". Regards, Slaven


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.