Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the CGI CPAN distribution.

Report information
The Basics
Id: 11786
Status: resolved
Priority: 0/
Queue: CGI

People
Owner: Nobody in particular
Requestors: tshinnic [...] io.com
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: (no value)
Fixed in: (no value)



Subject: checkbox_group code variable $columns misnamed
Download (untitled) / with headers
text/plain 859b
Trying to figure out the math in how checkbox_group() nicely reshapes the displayed table I noticed a typo. Line 2116 of version 3.05 should mention $columns rather than $cols. Code around that line currently reads: return wantarray ? @elements : join(' ',@elements) unless defined($columns) || defined($rows); $rows = 1 if $rows && $rows < 1; $cols = 1 if $cols && $cols < 1; return _tableize($rows,$columns,$rowheaders,$colheaders,@elements); I note also that very similar code in radio_group() is missing the two "= 1" lines and currently reads: return wantarray ? @elements : join(' ',@elements) unless defined($columns) || defined($rows); return _tableize($rows,$columns,$rowheaders,$colheaders,@elements); Just wondering if the motivation for the two lines really only applies to checkbox_group() and not also to radio_group().
Download (untitled) / with headers
text/plain 1.1k
I believe this bug report can considered "resolved" in 3.43 because related code appears to be completely rewritten and lines like the ones described no longer exist. Mark On Mon Mar 07 00:38:05 2005, guest wrote: Show quoted text
> Trying to figure out the math in how checkbox_group() nicely reshapes > the displayed table I noticed a typo. Line 2116 of version 3.05 > should mention $columns rather than $cols. Code around that line > currently reads: > return wantarray ? @elements : join(' ',@elements) > unless defined($columns) || defined($rows); > $rows = 1 if $rows && $rows < 1; > $cols = 1 if $cols && $cols < 1; > return _tableize($rows,$columns,$rowheaders,$colheaders,@elements); > > I note also that very similar code in radio_group() is missing the two > "= 1" lines and currently reads: > return wantarray ? @elements : join(' ',@elements) > unless defined($columns) || defined($rows); > return _tableize($rows,$columns,$rowheaders,$colheaders,@elements); > Just wondering if the motivation for the two lines really only applies > to checkbox_group() and not also to radio_group().


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.