Skip Menu |
 

This queue is for tickets about the Net-SSLeay CPAN distribution.

Report information
The Basics
Id: 117735
Status: open
Priority: 0/
Queue: Net-SSLeay

People
Owner: Nobody in particular
Requestors: AGRUNDMA [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in:
  • 1.75
  • 1.76
  • 1.77
  • 1.78
Fixed in: (no value)

Attachments


Subject: [PATCH] Fix inline variable declarations
Download (untitled) / with headers
text/plain 215b
One of the recent versions added a few inline variable declarations that cause errors for older compilers. Apologies if the patch looks weird, I tried to match the odd tab/space mix going on in this bit of the code.
Subject: Net-SSLeay-1.78-inline-variables.patch
From 67263d02ed713003572370931f3d3cc8a773600d Mon Sep 17 00:00:00 2001 From: Andy Grundman <andyg@activestate.com> Date: Fri, 9 Sep 2016 16:54:04 -0400 Subject: [PATCH] Fix inline variable declarations to make MSVC happy --- SSLeay.xs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/SSLeay.xs b/SSLeay.xs index abd7f42..8404d68 100644 --- a/SSLeay.xs +++ b/SSLeay.xs @@ -6043,6 +6043,8 @@ OCSP_response_results(rsp,...) OCSP_SINGLERESP *sir = NULL; OCSP_CERTID *certid = NULL; SV *idsv = NULL; + int first, status, revocationReason; + ASN1_GENERALIZEDTIME *revocationTime, *thisupdate, *nextupdate; if(getall) { sir = OCSP_resp_get0(bsr,i); @@ -6057,13 +6059,11 @@ OCSP_response_results(rsp,...) error = "failed to get OCSP certid from string"; goto end; } - int first = OCSP_resp_find(bsr, certid, -1); /* Find the first matching */ - if (first >= 0) - sir = OCSP_resp_get0(bsr,first); + first = OCSP_resp_find(bsr, certid, -1); /* Find the first matching */ + if (first >= 0) + sir = OCSP_resp_get0(bsr,first); } - int status, revocationReason; - ASN1_GENERALIZEDTIME *revocationTime, *thisupdate, *nextupdate; if (sir) { #if OPENSSL_VERSION_NUMBER >= 0x10100000L -- 2.8.1
Subject: Re: [rt.cpan.org #117735] [PATCH] Fix inline variable declarations
Date: Sat, 10 Sep 2016 13:07:22 +0200
To: bug-Net-SSLeay [...] rt.cpan.org
From: Mike McCauley <mikem [...] airspayce.com>
Download (untitled) / with headers
text/plain 1.9k
Thanks for the patch I'm travelling at the moment and won't get a chance to look closely until mid October Cheers Sent from my iPhone Show quoted text
> On 10 Sep 2016, at 11:28 AM, Andy Grundman via RT <bug-Net-SSLeay@rt.cpan.org> wrote: > > Sat Sep 10 05:28:52 2016: Request 117735 was acted upon. > Transaction: Ticket created by AGRUNDMA > Queue: Net-SSLeay > Subject: [PATCH] Fix inline variable declarations > Broken in: 1.75, 1.76, 1.77, 1.78 > Severity: Unimportant > Owner: Nobody > Requestors: AGRUNDMA@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=117735 > > > > One of the recent versions added a few inline variable declarations that cause errors for older compilers. Apologies if the patch looks weird, I tried to match the odd tab/space mix going on in this bit of the code. > From 67263d02ed713003572370931f3d3cc8a773600d Mon Sep 17 00:00:00 2001 From: Andy Grundman Date: Fri, 9 Sep 2016 16:54:04 -0400 Subject: [PATCH] Fix inline variable declarations to make MSVC happy --- SSLeay.xs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/SSLeay.xs b/SSLeay.xs index abd7f42..8404d68 100644 --- a/SSLeay.xs +++ b/SSLeay.xs @@ -6043,6 +6043,8 @@ OCSP_response_results(rsp,...) OCSP_SINGLERESP *sir = NULL; OCSP_CERTID *certid = NULL; SV *idsv = NULL; + int first, status, revocationReason; + ASN1_GENERALIZEDTIME *revocationTime, *thisupdate, *nextupdate; if(getall) { sir = OCSP_resp_get0(bsr,i); @@ -6057,13 +6059,11 @@ OCSP_response_results(rsp,...) error = "failed to get OCSP certid from string"; goto end; } - int first = OCSP_resp_find(bsr, certid, -1); /* Find the first matching */ - if (first >= 0) - sir = OCSP_resp_get0(bsr,first); + first = OCSP_resp_find(bsr, certid, -1); /* Find the first matching */ + if (first >= 0) + sir = OCSP_resp_get0(bsr,first); } - int status, revocationReason; - ASN1_GENERALIZEDTIME *revocationTime, *thisupdate, *nextupdate; if (sir) { #if OPENSSL_VERSION_NUMBER >= 0x10100000L -- 2.8.1
Subject: Re: [rt.cpan.org #117735] [PATCH] Fix inline variable declarations
Date: Thu, 20 Oct 2016 10:57:46 +1000
To: bug-Net-SSLeay [...] rt.cpan.org
From: Mike McCauley <mikem [...] airspayce.com>
Download (untitled) / with headers
text/plain 1009b
Hi Andy, Thanks for this patch and your previous one. Thery are now both in SVN 479 Sorry for the delay. Cheers. On Saturday, September 10, 2016 05:28:53 AM Andy Grundman via RT wrote: Show quoted text
> Sat Sep 10 05:28:52 2016: Request 117735 was acted upon. > Transaction: Ticket created by AGRUNDMA > Queue: Net-SSLeay > Subject: [PATCH] Fix inline variable declarations > Broken in: 1.75, 1.76, 1.77, 1.78 > Severity: Unimportant > Owner: Nobody > Requestors: AGRUNDMA@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=117735 > > > > One of the recent versions added a few inline variable declarations that > cause errors for older compilers. Apologies if the patch looks weird, I > tried to match the odd tab/space mix going on in this bit of the code.
-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.