Skip Menu |
 

This queue is for tickets about the File-Path CPAN distribution.

Report information
The Basics
Id: 117620
Status: resolved
Priority: 0/
Queue: File-Path

People
Owner: jkeenan [...] cpan.org
Requestors: dom [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 2.12
Fixed in: (no value)



Subject: [PATCH] Don't hardcode ENOENT
Download (untitled) / with headers
text/plain 190b
The attached patch, provided by Pino Toscano of the Debian project, fixes a test failure on GNU/Hurd because on that platform, ENOENT is not 2. This fixes a regression between 2.11 and 2.12.
Subject: file-path-errno.diff
--- a/t/Path.t +++ b/t/Path.t @@ -8,6 +8,7 @@ use Config; use Fcntl ':mode'; use lib 't/'; use FilePathTest; +use Errno qw(:POSIX); BEGIN { use_ok('Cwd'); @@ -656,7 +657,7 @@ is( { my ($x, $message, $object, $expect, $rv, $arg, $error); my ($k, $v, $second_error, $third_error); - local $! = 2; + local $! = ENOENT; $x = $!; $message = 'message in a bottle';
Download (untitled) / with headers
text/plain 355b
On Thu Sep 08 05:21:21 2016, DOM wrote: Show quoted text
> The attached patch, provided by Pino Toscano of the Debian project, > fixes a test failure on GNU/Hurd because on that platform, ENOENT is > not 2. This fixes a regression between 2.11 and 2.12.
Is there a Debian bug ticket or mailing list thread that we can reference for this? Thank you very much. Jim Keenan
Subject: Re: [rt.cpan.org #117620] [PATCH] Don't hardcode ENOENT
Date: Thu, 8 Sep 2016 13:40:19 +0100
To: James E Keenan via RT <bug-File-Path [...] rt.cpan.org>
From: Dominic Hargreaves <dom [...] earth.li>
Download (untitled) / with headers
text/plain 613b
On Thu, Sep 08, 2016 at 08:36:16AM -0400, James E Keenan via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=117620 > > > On Thu Sep 08 05:21:21 2016, DOM wrote:
> > The attached patch, provided by Pino Toscano of the Debian project, > > fixes a test failure on GNU/Hurd because on that platform, ENOENT is > > not 2. This fixes a regression between 2.11 and 2.12.
> > > Is there a Debian bug ticket or mailing list thread that we can reference for this?
There is a passing reference in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836892 but that's mainly about another issue. Dominic.
Download (untitled) / with headers
text/plain 293b
On Thu Sep 08 05:21:21 2016, DOM wrote: Show quoted text
> The attached patch, provided by Pino Toscano of the Debian project, > fixes a test failure on GNU/Hurd because on that platform, ENOENT is > not 2. This fixes a regression between 2.11 and 2.12.
Reference: https://github.com/rpcme/File-Path/pull/36
Download (untitled) / with headers
text/plain 415b
On Tue Sep 13 22:30:09 2016, JKEENAN wrote: Show quoted text
> On Thu Sep 08 05:21:21 2016, DOM wrote:
> > The attached patch, provided by Pino Toscano of the Debian project, > > fixes a test failure on GNU/Hurd because on that platform, ENOENT is > > not 2. This fixes a regression between 2.11 and 2.12.
> > > Reference: https://github.com/rpcme/File-Path/pull/36
Merged into rpcme/master Sep 16 2016, but awaits CPAN release.
Download (untitled) / with headers
text/plain 626b
On Wed Mar 08 16:09:51 2017, JKEENAN wrote: Show quoted text
> On Tue Sep 13 22:30:09 2016, JKEENAN wrote:
> > On Thu Sep 08 05:21:21 2016, DOM wrote:
> > > The attached patch, provided by Pino Toscano of the Debian project, > > > fixes a test failure on GNU/Hurd because on that platform, ENOENT is > > > not 2. This fixes a regression between 2.11 and 2.12.
> > > > > > Reference: https://github.com/rpcme/File-Path/pull/36
> > Merged into rpcme/master Sep 16 2016, but awaits CPAN release.
This change has been released to CPAN as part of the release of File-Path 2.13 today. Marking ticket Resolved. Thank you very much. Jim Keenan


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.