Skip Menu |
 

This queue is for tickets about the Socket CPAN distribution.

Report information
The Basics
Id: 116913
Status: resolved
Priority: 0/
Queue: Socket

People
Owner: Nobody in particular
Requestors: shay [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 2.025

Attachments
0001-Fix-build-and-tests-without-HAS_SOCKADDR_IN6-RT-1169.patch



Subject: Test failure (after fixing build failure) with 2.023 on Win32/VC++
Download (untitled) / with headers
text/plain 2.9k
I'm trying to update Socket to 2.023 in core, now that Configure has support for gai_strerror detection, but I've run into two problems just testing on my own Win32/VC++ setup: 1. The build fails. Easily fixed by: diff -ruN Socket-2.023.orig/Socket.xs Socket-2.023/Socket.xs --- Socket-2.023.orig/Socket.xs 2016-08-01 16:04:27.000000000 +0100 +++ Socket-2.023/Socket.xs 2016-08-12 08:28:15.097554600 +0100 @@ -1049,7 +1049,7 @@ # endif ST(0) = sv_2mortal(newSVpvn((char *)&sin6, sizeof(sin6))); #else - PERL_UNUSED_VAR(port); + PERL_UNUSED_VAR(port_sv); PERL_UNUSED_VAR(sin6_addr); ST(0) = (SV*)not_here("pack_sockaddr_in6"); #endif 2. sockaddr.t fails: C:\Dev\Git\perl\t>.\perl harness -v ..\cpan\Socket\t\sockaddr.t ../cpan/Socket/t/sockaddr.t .. 1..44 ok 1 - inet_aton returns packed bytes ok 2 - inet_ntoa from v-string ok 3 - inet_aton->inet_ntoa roundtrip ok 4 - inet_ntoa warns about wide characters ok 5 - inet_pton AF_INET returns packed bytes ok 6 - inet_ntop AF_INET from v-string ok 7 - inet_pton->inet_ntop AF_INET roundtrip ok 8 - inet_aton->inet_ntop AF_INET roundtrip ok 9 - inet_ntop warns about wide characters ok 10 - inet_pton AF_INET6 returns packed bytes ok 11 - inet_ntop AF_INET6 from octet string ok 12 - inet_pton->inet_ntop AF_INET6 roundtrip ok 13 - sockaddr_family warns about argument length ok 14 - pack_sockaddr_in defined ok 15 - sockaddr_family of pack_sockaddr_in ok 16 - pack_sockaddr_in->unpack_sockaddr_in port ok 17 - pack_sockaddr_in->unpack_sockaddr_in addr ok 18 - unpack_sockaddr_in in scalar context yields addr ok 19 - sockaddr_in in list context unpacks ok 20 - sockaddr_in in scalar context packs ok 21 - pack_sockaddr_in undef port is fatal ok 22 - pack_sockaddr_in undef addr is fatal ok 23 - unpack_sockaddr_in undef is fatal ok 24 - undefined values produced no warnings ok 25 # skip Cannot pack_sockaddr_in6() ok 26 # skip Cannot pack_sockaddr_in6() ok 27 # skip Cannot pack_sockaddr_in6()# Looks like you planned 44 tests but ran 40. ok 28 # skip Cannot pack_sockaddr_in6() ok 29 # skip Cannot pack_sockaddr_in6() ok 30 # skip Cannot pack_sockaddr_in6() ok 31 # skip Cannot pack_sockaddr_in6() ok 32 # skip Cannot pack_sockaddr_in6() ok 33 # skip Cannot pack_sockaddr_in6() ok 34 # skip Abstract AF_UNIX paths unsupported ok 35 # skip Abstract AF_UNIX paths unsupported ok 36 # skip Abstract AF_UNIX paths unsupported ok 37 # skip Abstract AF_UNIX paths unsupported ok 38 # skip Abstract AF_UNIX paths unsupported ok 39 - sockaddr_in deprecated form doesn't warn without lexical warnings ok 40 - sockaddr_in deprecated form warns with lexical warnings Dubious, test returned 255 (wstat 65280, 0xff00) Failed 4/44 subtests (less 14 skipped subtests: 26 okay) Test Summary Report ------------------- ../cpan/Socket/t/sockaddr.t (Wstat: 65280 Tests: 40 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 44 tests but ran 40. Files=1, Tests=40, 1 wallclock secs ( 0.00 usr + 0.02 sys = 0.02 CPU) Result: FAIL
Download (untitled) / with headers
text/plain 3.2k
On Fri Aug 12 03:48:35 2016, SHAY wrote: Show quoted text
> I'm trying to update Socket to 2.023 in core, now that Configure has > support for gai_strerror detection, but I've run into two problems > just testing on my own Win32/VC++ setup: > > 1. The build fails. Easily fixed by: > > diff -ruN Socket-2.023.orig/Socket.xs Socket-2.023/Socket.xs > --- Socket-2.023.orig/Socket.xs 2016-08-01 16:04:27.000000000 +0100 > +++ Socket-2.023/Socket.xs 2016-08-12 08:28:15.097554600 +0100 > @@ -1049,7 +1049,7 @@ > # endif > ST(0) = sv_2mortal(newSVpvn((char *)&sin6, sizeof(sin6))); > #else > - PERL_UNUSED_VAR(port); > + PERL_UNUSED_VAR(port_sv); > PERL_UNUSED_VAR(sin6_addr); > ST(0) = (SV*)not_here("pack_sockaddr_in6"); > #endif > > 2. sockaddr.t fails: > > C:\Dev\Git\perl\t>.\perl harness -v ..\cpan\Socket\t\sockaddr.t > ../cpan/Socket/t/sockaddr.t .. > 1..44 > ok 1 - inet_aton returns packed bytes > ok 2 - inet_ntoa from v-string > ok 3 - inet_aton->inet_ntoa roundtrip > ok 4 - inet_ntoa warns about wide characters > ok 5 - inet_pton AF_INET returns packed bytes > ok 6 - inet_ntop AF_INET from v-string > ok 7 - inet_pton->inet_ntop AF_INET roundtrip > ok 8 - inet_aton->inet_ntop AF_INET roundtrip > ok 9 - inet_ntop warns about wide characters > ok 10 - inet_pton AF_INET6 returns packed bytes > ok 11 - inet_ntop AF_INET6 from octet string > ok 12 - inet_pton->inet_ntop AF_INET6 roundtrip > ok 13 - sockaddr_family warns about argument length > ok 14 - pack_sockaddr_in defined > ok 15 - sockaddr_family of pack_sockaddr_in > ok 16 - pack_sockaddr_in->unpack_sockaddr_in port > ok 17 - pack_sockaddr_in->unpack_sockaddr_in addr > ok 18 - unpack_sockaddr_in in scalar context yields addr > ok 19 - sockaddr_in in list context unpacks > ok 20 - sockaddr_in in scalar context packs > ok 21 - pack_sockaddr_in undef port is fatal > ok 22 - pack_sockaddr_in undef addr is fatal > ok 23 - unpack_sockaddr_in undef is fatal > ok 24 - undefined values produced no warnings > ok 25 # skip Cannot pack_sockaddr_in6() > ok 26 # skip Cannot pack_sockaddr_in6() > ok 27 # skip Cannot pack_sockaddr_in6()# Looks like you planned 44 > tests but ran > 40. > > ok 28 # skip Cannot pack_sockaddr_in6() > ok 29 # skip Cannot pack_sockaddr_in6() > ok 30 # skip Cannot pack_sockaddr_in6() > ok 31 # skip Cannot pack_sockaddr_in6() > ok 32 # skip Cannot pack_sockaddr_in6() > ok 33 # skip Cannot pack_sockaddr_in6() > ok 34 # skip Abstract AF_UNIX paths unsupported > ok 35 # skip Abstract AF_UNIX paths unsupported > ok 36 # skip Abstract AF_UNIX paths unsupported > ok 37 # skip Abstract AF_UNIX paths unsupported > ok 38 # skip Abstract AF_UNIX paths unsupported > ok 39 - sockaddr_in deprecated form doesn't warn without lexical > warnings > ok 40 - sockaddr_in deprecated form warns with lexical warnings > Dubious, test returned 255 (wstat 65280, 0xff00) > Failed 4/44 subtests > (less 14 skipped subtests: 26 okay) > > Test Summary Report > ------------------- > ../cpan/Socket/t/sockaddr.t (Wstat: 65280 Tests: 40 Failed: 0) > Non-zero exit status: 255 > Parse errors: Bad plan. You planned 44 tests but ran 40. > Files=1, Tests=40, 1 wallclock secs ( 0.00 usr + 0.02 sys = 0.02 > CPU) > Result: FAIL
Trying again with the 2.024 release, but I still have both of these problems.
Download (untitled) / with headers
text/plain 3.4k
Same problem here. On Thu Nov 03 04:43:14 2016, SHAY wrote: Show quoted text
> On Fri Aug 12 03:48:35 2016, SHAY wrote:
> > I'm trying to update Socket to 2.023 in core, now that Configure has > > support for gai_strerror detection, but I've run into two problems > > just testing on my own Win32/VC++ setup: > > > > 1. The build fails. Easily fixed by: > > > > diff -ruN Socket-2.023.orig/Socket.xs Socket-2.023/Socket.xs > > --- Socket-2.023.orig/Socket.xs 2016-08-01 16:04:27.000000000 +0100 > > +++ Socket-2.023/Socket.xs 2016-08-12 08:28:15.097554600 +0100 > > @@ -1049,7 +1049,7 @@ > > # endif > > ST(0) = sv_2mortal(newSVpvn((char *)&sin6, sizeof(sin6))); > > #else > > - PERL_UNUSED_VAR(port); > > + PERL_UNUSED_VAR(port_sv); > > PERL_UNUSED_VAR(sin6_addr); > > ST(0) = (SV*)not_here("pack_sockaddr_in6"); > > #endif > > > > 2. sockaddr.t fails: > > > > C:\Dev\Git\perl\t>.\perl harness -v ..\cpan\Socket\t\sockaddr.t > > ../cpan/Socket/t/sockaddr.t .. > > 1..44 > > ok 1 - inet_aton returns packed bytes > > ok 2 - inet_ntoa from v-string > > ok 3 - inet_aton->inet_ntoa roundtrip > > ok 4 - inet_ntoa warns about wide characters > > ok 5 - inet_pton AF_INET returns packed bytes > > ok 6 - inet_ntop AF_INET from v-string > > ok 7 - inet_pton->inet_ntop AF_INET roundtrip > > ok 8 - inet_aton->inet_ntop AF_INET roundtrip > > ok 9 - inet_ntop warns about wide characters > > ok 10 - inet_pton AF_INET6 returns packed bytes > > ok 11 - inet_ntop AF_INET6 from octet string > > ok 12 - inet_pton->inet_ntop AF_INET6 roundtrip > > ok 13 - sockaddr_family warns about argument length > > ok 14 - pack_sockaddr_in defined > > ok 15 - sockaddr_family of pack_sockaddr_in > > ok 16 - pack_sockaddr_in->unpack_sockaddr_in port > > ok 17 - pack_sockaddr_in->unpack_sockaddr_in addr > > ok 18 - unpack_sockaddr_in in scalar context yields addr > > ok 19 - sockaddr_in in list context unpacks > > ok 20 - sockaddr_in in scalar context packs > > ok 21 - pack_sockaddr_in undef port is fatal > > ok 22 - pack_sockaddr_in undef addr is fatal > > ok 23 - unpack_sockaddr_in undef is fatal > > ok 24 - undefined values produced no warnings > > ok 25 # skip Cannot pack_sockaddr_in6() > > ok 26 # skip Cannot pack_sockaddr_in6() > > ok 27 # skip Cannot pack_sockaddr_in6()# Looks like you planned 44 > > tests but ran > > 40. > > > > ok 28 # skip Cannot pack_sockaddr_in6() > > ok 29 # skip Cannot pack_sockaddr_in6() > > ok 30 # skip Cannot pack_sockaddr_in6() > > ok 31 # skip Cannot pack_sockaddr_in6() > > ok 32 # skip Cannot pack_sockaddr_in6() > > ok 33 # skip Cannot pack_sockaddr_in6() > > ok 34 # skip Abstract AF_UNIX paths unsupported > > ok 35 # skip Abstract AF_UNIX paths unsupported > > ok 36 # skip Abstract AF_UNIX paths unsupported > > ok 37 # skip Abstract AF_UNIX paths unsupported > > ok 38 # skip Abstract AF_UNIX paths unsupported > > ok 39 - sockaddr_in deprecated form doesn't warn without lexical > > warnings > > ok 40 - sockaddr_in deprecated form warns with lexical warnings > > Dubious, test returned 255 (wstat 65280, 0xff00) > > Failed 4/44 subtests > > (less 14 skipped subtests: 26 okay) > > > > Test Summary Report > > ------------------- > > ../cpan/Socket/t/sockaddr.t (Wstat: 65280 Tests: 40 Failed: 0) > > Non-zero exit status: 255 > > Parse errors: Bad plan. You planned 44 tests but ran 40. > > Files=1, Tests=40, 1 wallclock secs ( 0.00 usr + 0.02 sys = 0.02 > > CPU) > > Result: FAIL
> > > Trying again with the 2.024 release, but I still have both of these > problems.
Subject: [PATCH] Test failure (after fixing build failure) with 2.023 on Win32/VC++
Download (untitled) / with headers
text/plain 3.5k
On 2016-11-03 08:43:14, SHAY wrote: Show quoted text
> On Fri Aug 12 03:48:35 2016, SHAY wrote:
> > I'm trying to update Socket to 2.023 in core, now that Configure has > > support for gai_strerror detection, but I've run into two problems > > just testing on my own Win32/VC++ setup: > > > > 1. The build fails. Easily fixed by: > > > > diff -ruN Socket-2.023.orig/Socket.xs Socket-2.023/Socket.xs > > --- Socket-2.023.orig/Socket.xs 2016-08-01 16:04:27.000000000 +0100 > > +++ Socket-2.023/Socket.xs 2016-08-12 08:28:15.097554600 +0100 > > @@ -1049,7 +1049,7 @@ > > # endif > > ST(0) = sv_2mortal(newSVpvn((char *)&sin6, sizeof(sin6))); > > #else > > - PERL_UNUSED_VAR(port); > > + PERL_UNUSED_VAR(port_sv); > > PERL_UNUSED_VAR(sin6_addr); > > ST(0) = (SV*)not_here("pack_sockaddr_in6"); > > #endif > > > > 2. sockaddr.t fails: > > > > C:\Dev\Git\perl\t>.\perl harness -v ..\cpan\Socket\t\sockaddr.t > > ../cpan/Socket/t/sockaddr.t .. > > 1..44 > > ok 1 - inet_aton returns packed bytes > > ok 2 - inet_ntoa from v-string > > ok 3 - inet_aton->inet_ntoa roundtrip > > ok 4 - inet_ntoa warns about wide characters > > ok 5 - inet_pton AF_INET returns packed bytes > > ok 6 - inet_ntop AF_INET from v-string > > ok 7 - inet_pton->inet_ntop AF_INET roundtrip > > ok 8 - inet_aton->inet_ntop AF_INET roundtrip > > ok 9 - inet_ntop warns about wide characters > > ok 10 - inet_pton AF_INET6 returns packed bytes > > ok 11 - inet_ntop AF_INET6 from octet string > > ok 12 - inet_pton->inet_ntop AF_INET6 roundtrip > > ok 13 - sockaddr_family warns about argument length > > ok 14 - pack_sockaddr_in defined > > ok 15 - sockaddr_family of pack_sockaddr_in > > ok 16 - pack_sockaddr_in->unpack_sockaddr_in port > > ok 17 - pack_sockaddr_in->unpack_sockaddr_in addr > > ok 18 - unpack_sockaddr_in in scalar context yields addr > > ok 19 - sockaddr_in in list context unpacks > > ok 20 - sockaddr_in in scalar context packs > > ok 21 - pack_sockaddr_in undef port is fatal > > ok 22 - pack_sockaddr_in undef addr is fatal > > ok 23 - unpack_sockaddr_in undef is fatal > > ok 24 - undefined values produced no warnings > > ok 25 # skip Cannot pack_sockaddr_in6() > > ok 26 # skip Cannot pack_sockaddr_in6() > > ok 27 # skip Cannot pack_sockaddr_in6()# Looks like you planned 44 > > tests but ran > > 40. > > > > ok 28 # skip Cannot pack_sockaddr_in6() > > ok 29 # skip Cannot pack_sockaddr_in6() > > ok 30 # skip Cannot pack_sockaddr_in6() > > ok 31 # skip Cannot pack_sockaddr_in6() > > ok 32 # skip Cannot pack_sockaddr_in6() > > ok 33 # skip Cannot pack_sockaddr_in6() > > ok 34 # skip Abstract AF_UNIX paths unsupported > > ok 35 # skip Abstract AF_UNIX paths unsupported > > ok 36 # skip Abstract AF_UNIX paths unsupported > > ok 37 # skip Abstract AF_UNIX paths unsupported > > ok 38 # skip Abstract AF_UNIX paths unsupported > > ok 39 - sockaddr_in deprecated form doesn't warn without lexical > > warnings > > ok 40 - sockaddr_in deprecated form warns with lexical warnings > > Dubious, test returned 255 (wstat 65280, 0xff00) > > Failed 4/44 subtests > > (less 14 skipped subtests: 26 okay) > > > > Test Summary Report > > ------------------- > > ../cpan/Socket/t/sockaddr.t (Wstat: 65280 Tests: 40 Failed: 0) > > Non-zero exit status: 255 > > Parse errors: Bad plan. You planned 44 tests but ran 40. > > Files=1, Tests=40, 1 wallclock secs ( 0.00 usr + 0.02 sys = 0.02 > > CPU) > > Result: FAIL
> > > Trying again with the 2.024 release, but I still have both of these > problems.
Attached is an updated patch which fixes both the build and the test skip count. - ilmari
Subject: 0001-Fix-build-and-tests-without-HAS_SOCKADDR_IN6-RT-1169.patch
From 0545dac8147bf6d56758cc2de9fea6ca2ef2f355 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dagfinn=20Ilmari=20Manns=C3=A5ker?= <ilmari@ilmari.org> Date: Sat, 28 Oct 2017 16:07:30 +0100 Subject: [PATCH] Fix build and tests without HAS_SOCKADDR_IN6 (RT#116913) - Fix sockaddr.t skip count - Fix variable name in PERL_UNUSED_VAR() --- Socket.xs | 2 +- t/sockaddr.t | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Socket.xs b/Socket.xs index 6139b78..8e8bc4e 100644 --- a/Socket.xs +++ b/Socket.xs @@ -1057,7 +1057,7 @@ pack_sockaddr_in6(port_sv, sin6_addr, scope_id=0, flowinfo=0) # endif ST(0) = sv_2mortal(newSVpvn((char *)&sin6, sizeof(sin6))); #else - PERL_UNUSED_VAR(port); + PERL_UNUSED_VAR(port_sv); PERL_UNUSED_VAR(sin6_addr); ST(0) = (SV*)not_here("pack_sockaddr_in6"); #endif diff --git a/t/sockaddr.t b/t/sockaddr.t index 7492eb3..9f17afb 100644 --- a/t/sockaddr.t +++ b/t/sockaddr.t @@ -98,8 +98,8 @@ SKIP: { # pack_sockaddr_in6, unpack_sockaddr_in6 # sockaddr_in6 SKIP: { - skip "No AF_INET6", 9 unless my $AF_INET6 = eval { Socket::AF_INET6() }; - skip "Cannot pack_sockaddr_in6()", 9 unless my $sin6 = eval { Socket::pack_sockaddr_in6(0x1234, "0123456789abcdef", 0, 89) }; + skip "No AF_INET6", 13 unless my $AF_INET6 = eval { Socket::AF_INET6() }; + skip "Cannot pack_sockaddr_in6()", 13 unless my $sin6 = eval { Socket::pack_sockaddr_in6(0x1234, "0123456789abcdef", 0, 89) }; ok(defined $sin6, 'pack_sockaddr_in6 defined'); -- 2.7.4
Thanks, applied. -- Paul Evans
Released in 2.025 -- Paul Evans


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.