Skip Menu |
 

This queue is for tickets about the CatalystX-Script-Server-Starman CPAN distribution.

Report information
The Basics
Id: 116910
Status: resolved
Priority: 0/
Queue: CatalystX-Script-Server-Starman

People
Owner: Nobody in particular
Requestors: gnuk0001 [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.03



Subject: [PATCH] Fix handling of '--fork' and '-f' command line arguments.
Date: Thu, 11 Aug 2016 17:08:43 -0300
To: bug-CatalystX-Script-Server-Starman [...] rt.cpan.org
From: Renzo Carbonara <gnuk0001 [...] gmail.com>
Download (untitled) / with headers
text/plain 1.2k
Parsing of command line switch fails if `init_arg` is specified, which is that can't be done for 'has +fork' anyway, according to https://en.wikibooks.org/wiki/Programming_with_Moose/Syntax/has#init_arg --- lib/CatalystX/Script/Server/Starman.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/CatalystX/Script/Server/Starman.pm b/lib/CatalystX/Script/Server/Starman.pm index 670bd74..7b3bd2e 100644 --- a/lib/CatalystX/Script/Server/Starman.pm +++ b/lib/CatalystX/Script/Server/Starman.pm @@ -9,7 +9,7 @@ our $VERSION = '0.02'; extends 'Catalyst::Script::Server'; -has '+fork' => ( default => 1, init_arg => undef ); +has '+fork' => ( default => 1 ); has [qw/ keepalive restart restart_delay restart_regex restart_directory/] => ( init_arg => undef, is => 'ro' ); @@ -70,7 +70,7 @@ CatalystX::Script::Server::Starman - Replace the development server with Starman -d --debug force debug mode -f --fork handle each request in a new process - (defaults to false) + (defaults to true) -? --help display this help and exits -h --host host (defaults to all) -p --port port (defaults to 3000) -- 2.8.3
Subject: Re: [rt.cpan.org #116910] AutoReply: [PATCH] Fix handling of '--fork' and '-f' command line arguments.
Date: Thu, 11 Aug 2016 17:32:41 -0300
To: bug-CatalystX-Script-Server-Starman [...] rt.cpan.org
From: Renzo Carbonara <gnuk0001 [...] gmail.com>
Download (untitled) / with headers
text/plain 100b
Some additional context about how this issue was found: https://github.com/NixOS/nixpkgs/pull/17673
Download (untitled) / with headers
text/plain 199b
As far as I can tell this is intentional as Starman is a preforking http server and only the docs are incorrect. I have fixed the docs to not include the fork option any more and released it as 0.03.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.