Skip Menu |
 

This queue is for tickets about the Encode CPAN distribution.

Report information
The Basics
Id: 116817
Status: resolved
Priority: 0/
Queue: Encode

People
Owner: Nobody in particular
Requestors: 'spro^^*%*^6ut# [...] &$%*c
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 2.86



Subject: [PATCH] Avoid a C++ comment
Please see the attached patch. You should be able to feed it straight to ‘git am’.
Subject: open_fGt2ICkX.txt
Download open_fGt2ICkX.txt
text/plain 1021b
From: Father Chrysostomos <sprout@cpan.org> Avoid a C++-style comment Perl still guarantees that it will compile under strict C89 compilers, which do not support // comments, and Encode is a core module. diff -rup Encode-2.85-Xc_TX5-orig/Encode.xs Encode-2.85-Xc_TX5/Encode.xs --- Encode-2.85-Xc_TX5-orig/Encode.xs 2016-08-03 20:16:05.000000000 -0700 +++ Encode-2.85-Xc_TX5/Encode.xs 2016-08-09 22:15:33.000000000 -0700 @@ -499,7 +499,9 @@ CODE: dSP; ENTER; SAVETMPS; if (src == &PL_sv_undef || SvROK(src)) src = sv_2mortal(newSV(0)); check = SvROK(check_sv) ? ENCODE_PERLQQ|ENCODE_LEAVE_SRC : SvIV(check_sv); - if (!(check & ENCODE_LEAVE_SRC) && SvIsCOW(src)) sv_force_normal(src); // disassociate from any other scalars before doing in-place modifications + if (!(check & ENCODE_LEAVE_SRC) && SvIsCOW(src)) + /* disassociate from any other scalars before doing in-place modifications */ + sv_force_normal(src); s = (U8 *) SvPV(src, slen); e = (U8 *) SvEND(src); /*
Download (untitled) / with headers
text/plain 258b
Fixed: https://github.com/dankogai/p5-encode/commit/0352ac06190766affa0a52565a321c6495ec5187 Dan the Maintainer Thereof On Wed Aug 10 01:17:45 2016, SPROUT wrote: Show quoted text
> Please see the attached patch. You should be able to feed it straight > to ‘git am’.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.