Skip Menu |
 

This queue is for tickets about the B-Hooks-Parser CPAN distribution.

Report information
The Basics
Id: 116680
Status: open
Priority: 0/
Queue: B-Hooks-Parser

People
Owner: Nobody in particular
Requestors: 'spro^^*%*^6ut# [...] &$%*c
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Undocumented and barely test toke functions
Download (untitled) / with headers
text/plain 388b
The B::Hooks::Toke package is made available by ‘use B::Hooks::Parser’ (‘use B::Hooks::Toke’ does not work). It is completely undocumented, and the only tests test that two of the three functions in it are defined and nothing more. Furthermore, at the C level, hook_toke_scan_str is exposed, but not at the Perl level. Should these be documented? Should they be tested better?
Download (untitled) / with headers
text/plain 587b
Show quoted text
> Furthermore, at the C level, hook_toke_scan_str is exposed, but not at > the Perl level. > > Should these be documented? Should they be tested better?
I would think that either hook_toke_scan_str should be documented (and possibly be usable in isolation), or it should not be exposed at the C level. grep.cpan.me tells me that signatures.xs uses hook_toke_scan_str, so perhaps the former? or should the API be restructured so signatures can do what it wants to do in a better way? (Please, anyone who is familiar with the relevant guts, chime in! I'm just the janitor here.) :)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.