Skip Menu |
 

This queue is for tickets about the XML-LibXML CPAN distribution.

Report information
The Basics
Id: 115859
Status: resolved
Priority: 0/
Queue: XML-LibXML

People
Owner: Nobody in particular
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 2.0126
Fixed in: (no value)

Attachments
XML-LibXML-2.0126-Disable-prereq_matches_use-Test-Kwalitee-Extra-subte.patch



Subject: t/release-kwalitee.t fails without Internet
Download (untitled) / with headers
text/plain 708b
The new t/release-kwalitee.t test fails if the Internet is not accessible: # Failed test 'prereq_matches_use by Test::Kwalitee::Extra' # at (eval 84) line 2. # Detail: This distribution uses a module or a dist that's not listed as a prerequisite. # Detail: Query error: Test::LeakTrace XML::NamespaceSupport XML::SAX XML::SAX::Base XML::SAX::DocumentLocator XML::SAX::Exception XML::SAX::ParserFactory parent perl # Remedy: Fix query error(s) to MetaCPAN. # Looks like you failed 1 test of 25. t/release-kwalitee.t ............................... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/25 subtests A work-around is disabling the prereq_matches_use subtest. See the attached patch.
Subject: XML-LibXML-2.0126-Disable-prereq_matches_use-Test-Kwalitee-Extra-subte.patch
From 28d50e7cbbe1953da4a26bb213805ab9e1762de9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Mon, 4 Jul 2016 15:43:30 +0200 Subject: [PATCH] Disable prereq_matches_use Test::Kwalitee::Extra subtest MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The prereq_matches_use subtest requires network access to <https://metacpan.org/>. Signed-off-by: Petr Písař <ppisar@redhat.com> --- t/release-kwalitee.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/release-kwalitee.t b/t/release-kwalitee.t index 47b8d6e..06ea857 100644 --- a/t/release-kwalitee.t +++ b/t/release-kwalitee.t @@ -7,4 +7,4 @@ use Test::More; # needed to provide plan. eval { require Test::Kwalitee::Extra }; plan skip_all => "Test::Kwalitee::Extra required for testing kwalitee: $@" if $@; -eval "use Test::Kwalitee::Extra"; +eval "use Test::Kwalitee::Extra qw(!prereq_matches_use)"; -- 2.5.5
Download (untitled) / with headers
text/plain 737b
On 2016-07-04 06:51:04, ppisar wrote: Show quoted text
> The new t/release-kwalitee.t test fails if the Internet is not > accessible:
While this test failure is indeed an issue that should be corrected, please don't allow pod, critic or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, both of which cannot be predicted in advance. Either move them to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};
should be fixed in 2.0127. Closing.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.