Skip Menu |
 

This queue is for tickets about the Template-Plugin-Textile CPAN distribution.

Report information
The Basics
Id: 11541
Status: open
Priority: 0/
Queue: Template-Plugin-Textile

People
Owner: Nobody in particular
Requestors: Smylers [...] stripey.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



Subject: Textile Output Test Failure
Download (untitled) / with headers
text/plain 1.5k
Hello there. Thanks for Template::Plugin::Textile. Unfortunately I get test failures when trying to install it. Also unfortunately I'm not yet familiar enough with Template Toolkit to coax the test harness into giving details of the output that didn't match, but I installed the module despite the test failures and have tried simulating them by hand. The first test is this: this is _like_ *so* *cool* for which the expected output is: <p>this is <em>like</em> <strong>so* *cool</strong></p> but the actual output is: <p>this is <em>like</em> <strong>so</strong> <strong>cool</strong></p> I'd never heard of Textile till I saw this module, and detailed documentation on its syntax seems to be scarce, but the actual output looks plausible to me. Perhaps this is something which has changed in Text::Textile since you first released Template::Plugin::Textile? The second test fails because the actual output has two blank lines between the end of the paragraph and the start of the list. I can think of no good reason for having multiple blank lines, but it does seem to be what Text::Textile emits. The third test fails because the actual output has <br /> tags in it at the start and end. Starting the first word ("The") immediately after the [% BLOCK %] tag, and having the closing [% END %] tag immediately after the last word ("2002") fixes this. But having to do that is tedious and irritating, and makes the template source less readable. I think I've seen a TT option somewhere for supressing whitespace (but haven't investigated it yet); perhaps that would help? Cheers. Smylers
Subject: Re: Textile Output Test Failure
From: Smylers [...] stripey.com
Download (untitled) / with headers
text/plain 582b
I just wrote: Show quoted text
> The third test fails because the actual output has <br /> tags in it > at the start and end.
I've now learnt what the minus signs mean at the start and end of TT tags. So the superfluous <br />s can be removed from this test output by putting them appropriately in the block start and end tags: [% text = BLOCK -%] [%- END%] I suspect that the output still has a superfluous blank line at the beginning (that is, a "\n" HTML _source_ blank line, not a <br> HTML output blank line), but that's hard to tell from running the test outside the harness. Smylers
Subject: [rt.cpan.org #11541] Textile Output Test Failure
Date: Mon, 7 Jan 2008 15:58:22 -0200
To: bug-Template-Plugin-Textile [...] rt.cpan.org
From: "Adriano Ferreira" <a.r.ferreira [...] gmail.com>
Download (untitled) / with headers
text/plain 330b
Hi, Mark. I would like you to consider the attached patch that solves the test failures of the dist by updating the dependency of Text::Textile into version 2.03. This Text::Textile version brings many features of the actual Textile especification which would be a plus in the use of your plugin. Kind regards, Adriano Ferreira
Download tp-textile.patch
text/x-diff 7.4k

Message body is not shown because sender requested not to inline it.

RT-Send-CC: a.r.ferreira [...] gmail.com
Download (untitled) / with headers
text/plain 128b
Hello one and all. I suck. It's been four years. But I've now fixed this issue in 2.00, heading to a CPAN near you. Mark.
Subject: Re: [rt.cpan.org #11541] Textile Output Test Failure
Date: Fri, 17 Feb 2012 15:49:28 +0000
To: MARKF via RT <bug-Template-Plugin-Textile [...] rt.cpan.org>
From: Smylers <Smylers [...] stripey.com>
Download (untitled) / with headers
text/plain 248b
Hi Mark. What a lovely surprise! Thanks for fixing this. Unfortunately I think the module's synopsis still needs tweaking to match; it still gives the example output as: <p>this is <em>like</em> <strong>so* *cool</strong></p> Cheers Smylers
Subject: Re: [rt.cpan.org #11541] Textile Output Test Failure
Date: Fri, 17 Feb 2012 16:35:53 +0000
To: bug-Template-Plugin-Textile [...] rt.cpan.org
From: Mark Fowler <mark [...] twoshortplanks.com>
Download (untitled) / with headers
text/plain 571b
Oh good. And there I was thinking I wouldn't have a module to release this week. On Fri, Feb 17, 2012 at 3:49 PM, Smylers@stripey.com via RT <bug-Template-Plugin-Textile@rt.cpan.org> wrote: Show quoted text
>       Queue: Template-Plugin-Textile >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=11541 > > > Hi Mark. What a lovely surprise! Thanks for fixing this. > > Unfortunately I think the module's synopsis still needs tweaking to > match; it still gives the example output as: > >  <p>this is <em>like</em> <strong>so* *cool</strong></p> > > Cheers > > Smylers > >


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.