Skip Menu |
 

This queue is for tickets about the Encode CPAN distribution.

Report information
The Basics
Id: 115314
Status: open
Priority: 0/
Queue: Encode

People
Owner: Nobody in particular
Requestors: 'spro^^*%*^6ut# [...] &$%*c
Cc: pali [...] cpan.org
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 2.87



Subject: Fails tests with Test::More 0.47
Download (untitled) / with headers
text/plain 277b
t/encoding-locale..........Undefined subroutine &main::note called at t/encoding-locale.t line 25. # Looks like your test died just after 3. The note() function was added in Test::More 0.82, so please either declare the dependency on that version or avoid using that function.
Download (untitled) / with headers
text/plain 418b
On Mon Jun 13 18:41:39 2016, SPROUT wrote: Show quoted text
> t/encoding-locale..........Undefined subroutine &main::note called at > t/encoding-locale.t line 25. > # Looks like your test died just after 3. > > The note() function was added in Test::More 0.82, so please either > declare the dependency on that version or avoid using that function.
fixed in: https://github.com/dankogai/p5-encode/pull/55 Dan the Encode Maintainer
Download (untitled) / with headers
text/plain 102b
That pull request did not take old ExtUtils::MakeMaker versions into account. See the attached patch.
Subject: open_rLidKcB3.txt
Download open_rLidKcB3.txt
text/plain 1.1k
From bdbe76a740c54d410733fc99390c33ecc28a161d Mon Sep 17 00:00:00 2001 From: Father Chrysostomos <sprout@cpan.org> Date: Wed, 15 Jun 2016 10:40:29 -0700 Subject: [PATCH] Support old EUMM for test prereqs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In versions that don’t support TEST_REQUIRES, use BUILD_REQUIRES. In versions that don’t support BUILD_REQUIRES, use PREREQ_PM. diff --git a/Makefile.PL b/Makefile.PL index cd4d98f..2cd49fc 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -35,7 +35,7 @@ my @pmlibdirs = qw(lib Encode); $ARGV{MORE_SCRIPTS} and push @exe_files, @more_exe_files; $ARGV{INSTALL_UCM} and push @pmlibdirs, "ucm"; -WriteMakefile( +my %makefile_args = ( NAME => "Encode", EXE_FILES => \@exe_files, VERSION_FROM => 'Encode.pm', @@ -63,6 +63,18 @@ WriteMakefile( }, ); +if ($ExtUtils::MakeMaker::VERSION < 6.55_01) { + for ($makefile_args{PREREQ_PM}) { + %$_ = (%$_, %{delete $makefile_args{TEST_REQUIRES}}); + } +} +elsif ($ExtUtils::MakeMaker::VERSION < 6.63_03) { + $makefile_args{BUILD_REQUIRES} = delete $makefile_args{TEST_REQUIRES}; +} + +WriteMakefile(%makefile_args); + + package MY;
Download (untitled) / with headers
text/plain 400b
On Pon Jún 13 18:41:39 2016, SPROUT wrote: Show quoted text
> t/encoding-locale..........Undefined subroutine &main::note called at > t/encoding-locale.t line 25. > # Looks like your test died just after 3. > > The note() function was added in Test::More 0.82, so please either > declare the dependency on that version or avoid using that function.
This should fix it: https://github.com/dankogai/p5-encode/pull/69


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.