Skip Menu |
 

This queue is for tickets about the Coro CPAN distribution.

Report information
The Basics
Id: 114708
Status: open
Priority: 0/
Queue: Coro

People
Owner: Nobody in particular
Requestors: alexchandel [...] gmail.com
Cc: gregoa [...] cpan.org
AdminCc:

Bug Information
Severity: Important
Broken in:
  • 6.49
  • 6.511
Fixed in: (no value)



Subject: Build failure with perl 5.24
Download (untitled) / with headers
text/plain 803b
On OX X 10.11.5, perl 5.24: cc -c -fno-common -DPERL_DARWIN -mmacosx-version-min=10.11 -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -DPERL_USE_SAFE_PUTENV -O3 -DVERSION=\"6.49\" -DXS_VERSION=\"6.49\" "-I/usr/local/Cellar/perl/5.24.0/lib/5.24.0/darwin-thread-multi-2level/CORE" -DCORO_SJLJ -DCORO_STACKSIZE=16384 -DCORO_GUARDPAGES=4 -DCORO_JIT=1 State.c State.xs:1398:92: error: no member named 'argarray' in 'struct block_sub' PUSHs (CxHASARGS (cx) ? sv_2mortal (newRV_inc ((SV *)cx->blk_sub.argarray)) : &PL_... ... State.xs:3604:81: error: read-only variable is not assignable orig_sigelem_get = PL_vtbl_sigelem.svt_get; PL_vtbl_sigelem.svt_get = coro_sigelem_get; ... The second error occurs similarly on two other lines.
Download (untitled) / with headers
text/plain 100b
Here's the patch applied in Debian which fixes the build failure for coro 6.511 on perl 5.24.1~rc3.
Subject: coro-5.24.patch
Download coro-5.24.patch
text/x-diff 941b
Description: fix for Coro with 5.24 Origin: https://paste.debian.net/688072 Bug-Debian: https://bugs.debian.org/838851 Bug: https://rt.cpan.org/Public/Bug/Display.html?id=114708 Author: Anonymous Last-Update: 2016-09-25 --- a/Coro/State.xs +++ b/Coro/State.xs @@ -1412,7 +1412,11 @@ PUSHMARK (SP); PUSHs (&PL_sv_yes); PUSHs (fullname); +# if PERL_VERSION_ATLEAST(5,24,0) + PUSHs (CxHASARGS (cx) ? sv_2mortal (newRV_inc (PL_curpad[0])) : &PL_sv_undef); +#else PUSHs (CxHASARGS (cx) ? sv_2mortal (newRV_inc ((SV *)cx->blk_sub.argarray)) : &PL_sv_undef); +#endif PUTBACK; cb = hv_fetch ((HV *)SvRV (coro_current), "_trace_sub_cb", sizeof ("_trace_sub_cb") - 1, 0); if (cb) call_sv (*cb, G_KEEPERR | G_EVAL | G_VOID | G_DISCARD);
From: alexchandel [...] gmail.com
Download (untitled) / with headers
text/plain 193b
On Mon Sep 26 12:42:54 2016, GREGOA wrote: Show quoted text
> Here's the patch applied in Debian which fixes the build failure for > coro 6.511 on perl 5.24.1~rc3.
Does this patch work with 5.26 and/or 6.514?
Subject: Re: [rt.cpan.org #114708] Build failure with perl 5.24
Date: Tue, 20 Mar 2018 06:18:15 +0100
To: "alexchandel [...] gmail.com via RT" <bug-Coro [...] rt.cpan.org>
From: Marc Lehmann <schmorp [...] schmorp.de>
Hi! Please send your bug report to the official contact/author address for the module in question (or send it to rt.cpan.org@schmorp.de, that's fine as well). What follows is the rationale for this request, you don't have to read it if you don't care. Why is this necessary? rt.cpan.org has many deficiencies which makes it tedious and hard to use, increasing the workload on the people who provide all the perl modules you probably appreciate (and that is really to be avoided - module authors should be able to invest all their time into improving their modules and not fighting with rt.cpan.org's bugs). Still, for some people, rt.cpan.org is useful to have, and some people even like it and really want to use it. That is fine, too. Unfortunately, the designers of rt.cpan.org didn't make their "service" optional - you can neither opt-in nor opt-out of rt.cpan.org as a module author. Just like a spammer, rt.cpan.org forces its "service" (whether wanted or unwanted) on everybody. Just like a spammer, they don't care for the people they actively hurt. Just like a spammer, they don't don't care to fix these issues and make their "service" ethically acceptable. You cannot even configure it to redirect tickets to somewhere else. Unfortunately, ignoring rt.cpan.org is not an option either: for people reporting possible bugs there is no indication that their report will be ignored, and for module authors it means they miss potentially vital bug reports such as yours (and of course it's a great impression if rt.cpan.org has lots of bug reports that are unanswered, making a module look unmaintained when in fact the opposite might be true). I am sorry that this wasted a bit of your time, but please understand that I am just as much a victim as you are - the problem is the unethical stance of the rt.cpan.org providers who force their "service" on everybody. Please redirect your bug report as stated in the beginning of this mail, and please consider petitioning the rt.cpan.org providers to stop their unethical behaviour and allow opt-in, opt-out, or some redirect option. One last issue: many people mail me that this can be "fixed" by including the bugtracker element in my module meta file. This is not true: 1. This field only affects search.cpan.org and maybe similar services. (Many people confuse rt.cpan.org with search.cpan.org for some reason). 2. It doesn't even work (there are still links to rt.cpan.org displayed). 3. Even if search.cpan.org does no longer display the link, it doesn't actually affect rt.cpan.org (and tests have shown that people go to rt.cpan.org regardless) Even *iff* rt.cpan.org would start listening on the bugtracker field, however, it's still wrong. I have a lot of modules, and each time a service like rt.cpan.org comes out, I would have to make dummy releases for all my modules. This not only creates a lot of extra work for me (I take releases very seriously) but also users, who would wonder why there is a new release. Thanks a lot, Marc Lehmann <rt.cpan.org@schmorp.de> Last updated: 2012-04-22
Subject: Re: [rt.cpan.org #114708] Build failure with perl 5.24
Date: Tue, 20 Mar 2018 08:28:16 +0100
To: "alexchandel [...] gmail.com via RT" <bug-Coro [...] rt.cpan.org>
From: gregor herrmann <gregoa [...] debian.org>
Download (untitled) / with headers
text/plain 995b
On Tue, 20 Mar 2018 00:18:24 -0400, alexchandel@gmail.com via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=114708 > > > On Mon Sep 26 12:42:54 2016, GREGOA wrote:
> > Here's the patch applied in Debian which fixes the build failure for > > coro 6.511 on perl 5.24.1~rc3.
> Does this patch work with 5.26 and/or 6.514?
This patch has been dropped as applied upstream in the Debian package for 6.514 (with perl 5.26). Cf. https://salsa.debian.org/perl-team/modules/packages/libcoro-perl/blob/master/debian/changelog and https://salsa.debian.org/perl-team/modules/packages/libcoro-perl/tree/master/debian/patches (remaining trivial patches, like typos) Cheers, gregor -- .''`. https://info.comodo.priv.at/ - Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- BOFH excuse #153: Big to little endian conversion error


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.