Skip Menu |
 

This queue is for tickets about the MailTools CPAN distribution.

Report information
The Basics
Id: 114382
Status: resolved
Priority: 0/
Queue: MailTools

People
Owner: Nobody in particular
Requestors: rjbs [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 2.18



Subject: Mail::Internet v2.17 breaks Email::Abstract
Download (untitled) / with headers
text/plain 240b
I'm not sure just what's up, but now all the tests end up getting messages with empty bodies. I haven't changed a thing. v2.16 worked. Obvious to you? http://www.cpantesters.org/cpan/report/9f478190-19d3-11e6-9bf9-817a9220e041 -- rjbs
Subject: Re: [rt.cpan.org #114382] Mail::Internet v2.17 breaks Email::Abstract
Date: Sun, 15 May 2016 11:58:40 +0200
To: Ricardo Signes via RT <bug-MailTools [...] rt.cpan.org>
From: Mark Overmeer <mark [...] overmeer.net>
Download (untitled) / with headers
text/plain 1.3k
* Ricardo Signes via RT (bug-MailTools@rt.cpan.org) [160514 19:43]: Show quoted text
> Sat May 14 15:43:39 2016: Request 114382 was acted upon. > Transaction: Ticket created by RJBS > Queue: MailTools > Subject: Mail::Internet v2.17 breaks Email::Abstract > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=114382 > > > I'm not sure just what's up, but now all the tests end up getting > messages with empty bodies. I haven't changed a thing. v2.16 worked. > > Obvious to you? > http://www.cpantesters.org/cpan/report/9f478190-19d3-11e6-9bf9-817a9220e041
CPAN-testers does not work, at the moment. And I cannot reproduce the error with your latest releases. Someone asked be to handled incorrectly folded headers better. I tried to modernize the parsing of the header a bit, but first broke MIME::Tools regression tests (not applications) and now apparently Email::Abstract. But not on my system. The changes were in Mail::Header::extract() and ::read() Blank lines before the headers? P.S: thanks for the many years of carying the incredible responsibility of Perl Core! -- Regards, MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net
Download (untitled) / with headers
text/plain 175b
It breaks on my notebook running Xubuntu 16.04 64bit with perlbrewed 5.24.0 -Duselargefiles -Duserelocatableinc -Duse64bitall Ping me on IRC if I can help debugging the issue.
Subject: Re: [rt.cpan.org #114382] Mail::Internet v2.17 breaks Email::Abstract
Date: Wed, 18 May 2016 12:03:42 +0200
To: Alexander Hartmaier via RT <bug-MailTools [...] rt.cpan.org>
From: Mark Overmeer <mark [...] overmeer.net>
* Alexander Hartmaier via RT (bug-MailTools@rt.cpan.org) [160518 07:53]: Show quoted text
> Queue: MailTools > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=114382 > > > It breaks on my notebook running Xubuntu 16.04 64bit with perlbrewed > 5.24.0 -Duselargefiles -Duserelocatableinc -Duse64bitall > Ping me on IRC if I can help debugging the issue.
Ok, the cause is clear now: it has to do with \r?\n In 2.14, I changed the accidentally succesful code into /^\s$/ to indicate the end of a header. That broke a regression-test in MIMETools which did not get repaired fast enough, to my feeling. In 2.16, I changed it into /^$/ which is more sensitive on the open mode of the file... in this case, there is a \r in the way. I'll release a fix tonight. -- Regards, MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net
I can confirm that 2.18 fixes the issue, thanks Mark!
Subject: Re: [rt.cpan.org #114382] Mail::Internet v2.17 breaks Email::Abstract
Date: Thu, 23 Jun 2016 21:37:46 -0400
To: Mark Overmeer via RT <bug-MailTools [...] rt.cpan.org>
From: Ricardo Signes <rjbs [...] cpan.org>
Download (untitled) / with headers
text/plain 344b
* Mark Overmeer via RT <bug-MailTools@rt.cpan.org> [2016-05-15T05:58:59] Show quoted text
> P.S: thanks for the many years of carying the incredible responsibility > of Perl Core!
I am pleased that I didn't screw things up too badly! Thanks for all your work, too, and for sorting out this bug. (Sorry it took me a month and a half to reply!) -- rjbs
Download signature.asc
application/pgp-signature 473b

Message body not shown because it is not plain text.

Fixed last May
Fixed last May


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.