Skip Menu |
 
rt.cpan.org will be shut down on March 1st, 2021.

This queue is for tickets about the DBD-SQLite CPAN distribution.

Report information
The Basics
Id: 114138
Status: stalled
Priority: 0/
Queue: DBD-SQLite

People
Owner: Nobody in particular
Requestors: vlmarek [...] volny.cz
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments


Subject: Non-local sqlite build still uses local sqlite3.h file
Download (untitled) / with headers
text/plain 352b
Hi, There are two problems a) Makefile.PL prepends -I. include path to the compilation command, so local directory is searched first b) sqlite3.h is being included by #include "sqlite3.h" instead of #include <sqlite3.h> Which again makes local directory searched first. I'm attaching the patch I am using to overcome this. Thank you __ Vlad
Subject: 03_do_not_use_local_header.patch
--- DBD-SQLite-1.50/Makefile.PL 2016-05-02 13:32:35.562004677 -0700 +++ DBD-SQLite-1.50/Makefile.PL 2016-05-02 13:31:31.215124807 -0700 @@ -170,6 +170,7 @@ if ( 0 ) { while ( defined($_ = <$fh>) ) { if (/\#define\s+SQLITE_VERSION_NUMBER\s+(\d+)/) { $version = $1; + $sqlite_inc = File::Spec->catdir( '', @$dir ); last; } } @@ -216,7 +217,7 @@ my @CC_INC = ( '-I$(DBI_INSTARCH_DIR)', ); if ( $sqlite_inc ) { - push @CC_INC, "-I$sqlite_inc"; + unshift @CC_INC, "-I$sqlite_inc"; } my @CC_DEFINE = ( --- DBD-SQLite-1.50/sqlite3ext.h 2016-05-02 13:40:28.734661242 -0700 +++ DBD-SQLite-1.50/sqlite3ext.h 2016-05-02 13:39:16.724889276 -0700 @@ -17,7 +17,7 @@ */ #ifndef _SQLITE3EXT_H_ #define _SQLITE3EXT_H_ -#include "sqlite3.h" +#include <sqlite3.h> typedef struct sqlite3_api_routines sqlite3_api_routines; --- DBD-SQLite-1.50/dbdimp.h 2016-05-02 13:40:28.956772954 -0700 +++ DBD-SQLite-1.50/dbdimp.h 2016-05-02 13:39:23.563370124 -0700 @@ -3,7 +3,7 @@ #define _DBDIMP_H 1 #include "SQLiteXS.h" -#include "sqlite3.h" +#include <sqlite3.h> #define MY_CXT_KEY "DBD::SQLite::_guts" XS_VERSION --- DBD-SQLite-1.50/SQLiteXS.h 2016-05-02 13:40:29.181387425 -0700 +++ DBD-SQLite-1.50/SQLiteXS.h 2016-05-02 13:39:36.956291908 -0700 @@ -18,7 +18,7 @@ #include "dbivport.h" #include <dbd_xsh.h> -#include "sqlite3.h" +#include <sqlite3.h> #include "fts3_tokenizer.h" #endif
Download (untitled) / with headers
text/plain 680b
On Tue May 03 06:11:32 2016, neuron wrote: Show quoted text
> Hi, > > There are two problems > > a) Makefile.PL prepends -I. include path to the compilation command, > so local directory is searched first > > b) sqlite3.h is being included by > > #include "sqlite3.h" > > instead of > > #include <sqlite3.h> > > Which again makes local directory searched first. > > I'm attaching the patch I am using to overcome this. > > Thank you > __ > Vlad
Thanks for sharing the patch. I'm not going to apply this because you need a patch to use non-local SQLite anyway to modify Makefile.PL, but this is much appreciated. Marked "stalled" to keep this visible to others who want to do the same.
From: vlmarek [...] volny.cz
Thank you for looking into this! __ Vlad
Changed the status to stalled again.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.