Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Dist-Zilla CPAN distribution.

Report information
The Basics
Id: 113590
Status: resolved
Priority: 0/
Queue: Dist-Zilla

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 5.044



Subject: 2.1700-TRIAL breaks Dist::Zilla 5.043 (maybe)
Download (untitled) / with headers
text/plain 4.8k
Evidence is not 100%, but it seems that the recent trial breaks the Dist::Zilla test suite and other Dist::Zilla-related modules. First these two test cases, seems to be related to List::MoreUtils: Array found where operator expected at /tmpfs/.cpan-build-cpansand/2016040606/Dist-Zilla-5.043-u0uCX0/blib/lib/Dist/Zilla/Plugin/AutoPrereqs.pm line 210, at end of line (Missing operator before ?) syntax error at /tmpfs/.cpan-build-cpansand/2016040606/Dist-Zilla-5.043-u0uCX0/blib/lib/Dist/Zilla/Plugin/AutoPrereqs.pm line 210, near "List::MoreUtils::uniq @modules" Compilation failed in require at /opt/perl-5.22.0t/lib/site_perl/5.22.0/Module/Runtime.pm line 317, <GEN0> line 12. at /home/cpansand/.cpan/build/2016040606/Config-MVP-2.200010-3aJbCY/blib/lib/Config/MVP/Assembler.pm line 144. t/plugins/autoprereqs.t ...... Dubious, test returned 255 (wstat 65280, 0xff00) No subtests run Array found where operator expected at /tmpfs/.cpan-build-cpansand/2016040606/Dist-Zilla-5.043-u0uCX0/blib/lib/Dist/Zilla/Plugin/AutoPrereqs.pm line 210, at end of line (Missing operator before ?) syntax error at /tmpfs/.cpan-build-cpansand/2016040606/Dist-Zilla-5.043-u0uCX0/blib/lib/Dist/Zilla/Plugin/AutoPrereqs.pm line 210, near "List::MoreUtils::uniq @modules" Compilation failed in require at /opt/perl-5.22.0t/lib/site_perl/5.22.0/Module/Runtime.pm line 317, <GEN0> line 12. at /home/cpansand/.cpan/build/2016040606/Config-MVP-2.200010-3aJbCY/blib/lib/Config/MVP/Assembler.pm line 144. t/plugins/extratests.t ....... Dubious, test returned 255 (wstat 65280, 0xff00) No subtests run And then this one: # Failed test 'all prereqs listed as output' # at t/commands/listdeps.t line 39. # Comparing $data as a Bag # Missing: 'DZPA::Base::Moose1', 'DZPA::Base::Moose2', 'DZPA::Base::base1', 'DZPA::Base::base2', 'DZPA::Base::base3', 'DZPA::Base::parent1', 'DZPA::Base::parent2', 'DZPA::Base::parent3', 'DZPA ::IgnoreAPI', 'DZPA::IndentedRequire', 'DZPA::IndentedUse', 'DZPA::MinVerComment', 'DZPA::ModRequire', 'DZPA::NotInDist', 'DZPA::Role', 'DZPA::ScriptUse', 'base', 'lib', 'parent', 'strict', 'w arnings' # Extra: ' (Missing operator before ?)', 'Array found where operator expected at /tmpfs/.cpan-build-cpansand/2016040606/Dist-Zilla-5.043-u0uCX0/blib/lib/Dist/Zilla/Plugin/AutoPrereqs.pm l ine 210, at end of line' # Failed test 'prereqs listed with versions for --versions' # at t/commands/listdeps.t line 48. # Comparing $data as a Bag # Missing: 'DZPA::Base::Moose1 = 0', 'DZPA::Base::Moose2 = 0', 'DZPA::Base::base1 = 0', 'DZPA::Base::base2 = 0', 'DZPA::Base::base3 = 0', 'DZPA::Base::parent1 = 0', 'DZPA::Base::parent2 = 0', 'DZPA::Base::parent3 = 0', 'DZPA::IgnoreAPI = 0', 'DZPA::IndentedRequire = 3.45', 'DZPA::IndentedUse = 0.13', 'DZPA::MinVerComment = 0.50', 'DZPA::ModRequire = 0', 'DZPA::NotInDist = 0', 'DZPA ::Role = 0', 'DZPA::ScriptUse = 0', 'base = 0', 'lib = 0', 'parent = 0', 'strict = 0', 'warnings = 0' # Failed test 'develop prereqs included in output for --author' # at t/commands/listdeps.t line 58. # Comparing $data as a Bag # Missing: 'DZPA::Base::Moose1', 'DZPA::Base::Moose2', 'DZPA::Base::base1', 'DZPA::Base::base2', 'DZPA::Base::base3', 'DZPA::Base::parent1', 'DZPA::Base::parent2', 'DZPA::Base::parent3', 'DZPA ::IgnoreAPI', 'DZPA::IndentedRequire', 'DZPA::IndentedUse', 'DZPA::MinVerComment', 'DZPA::ModRequire', 'DZPA::NotInDist', 'DZPA::Role', 'DZPA::ScriptUse', 'String::Formatter', 'base', 'lib', ' parent', 'strict', 'warnings' # Failed test 'develop prereqs included in output for --develop' # at t/commands/listdeps.t line 58. # Comparing $data as a Bag # Missing: 'DZPA::Base::Moose1', 'DZPA::Base::Moose2', 'DZPA::Base::base1', 'DZPA::Base::base2', 'DZPA::Base::base3', 'DZPA::Base::parent1', 'DZPA::Base::parent2', 'DZPA::Base::parent3', 'DZPA::IgnoreAPI', 'DZPA::IndentedRequire', 'DZPA::IndentedUse', 'DZPA::MinVerComment', 'DZPA::ModRequire', 'DZPA::NotInDist', 'DZPA::Role', 'DZPA::ScriptUse', 'String::Formatter', 'base', 'lib', 'parent', 'strict', 'warnings' # Looks like you failed 4 tests of 4. t/commands/listdeps.t ........ Dubious, test returned 4 (wstat 1024, 0x400) Failed 4/4 subtests Statistical analysis of test reports from my smokers shows the following result: **************************************************************** Regression 'mod:Moose' **************************************************************** Name Theta StdErr T-stat [0='const'] 1.0000 0.1651 6.06 [1='eq_2.1403'] 0.0000 0.2335 0.00 [2='eq_2.1600'] 0.0000 0.2335 0.00 [3='eq_2.1603'] 0.0000 0.2023 0.00 [4='eq_2.1604'] -0.0455 0.1670 -0.27 [5='eq_2.1605'] 0.0000 0.1714 0.00 [6='eq_2.1700'] -1.0000 0.1706 -5.86 R^2= 0.856, N= 77, K= 7 ****************************************************************
Download (untitled) / with headers
text/plain 483b
On 2016-04-06 12:25:11, SREZIC wrote: Show quoted text
> Evidence is not 100%, but it seems that the recent trial breaks the > Dist::Zilla test suite and other Dist::Zilla-related modules. > > First these two test cases, seems to be related to List::MoreUtils:
Looks like Dist-Zilla is failing to list List::MoreUtils as a prerequisite, which it needs to do now that Moose is no longer bringing it in. (Or, rjbs can merge the PR I've sent him that removes List::MoreUtils from Dist::Zilla as well.)
Download (untitled) / with headers
text/plain 776b
On 2016-04-06 13:04:54, ETHER wrote: Show quoted text
> On 2016-04-06 12:25:11, SREZIC wrote:
> > Evidence is not 100%, but it seems that the recent trial breaks the > > Dist::Zilla test suite and other Dist::Zilla-related modules. > > > > First these two test cases, seems to be related to List::MoreUtils:
> > Looks like Dist-Zilla is failing to list List::MoreUtils as a > prerequisite, which it needs to do now that Moose is no longer > bringing it in. (Or, rjbs can merge the PR I've sent him that removes > List::MoreUtils from Dist::Zilla as well.)
Actually it looks like LMU *is* listed in the prereqs! https://metacpan.org/source/RJBS/Dist-Zilla-5.043/META.json#L78 I do not see why the code should be exploding, unless something broke on the smoker and LMU did not get installed.
On 2016-04-06 16:55:53, ETHER wrote: Show quoted text
> On 2016-04-06 13:04:54, ETHER wrote:
> > On 2016-04-06 12:25:11, SREZIC wrote:
> > > Evidence is not 100%, but it seems that the recent trial breaks the > > > Dist::Zilla test suite and other Dist::Zilla-related modules. > > > > > > First these two test cases, seems to be related to List::MoreUtils:
> > > > Looks like Dist-Zilla is failing to list List::MoreUtils as a > > prerequisite, which it needs to do now that Moose is no longer > > bringing it in. (Or, rjbs can merge the PR I've sent him that removes > > List::MoreUtils from Dist::Zilla as well.)
> > Actually it looks like LMU *is* listed in the prereqs! > https://metacpan.org/source/RJBS/Dist-Zilla-5.043/META.json#L78 > > I do not see why the code should be exploding, unless something broke > on the smoker and LMU did not get installed.
LMU is already installed here (0.413). List::Util is the latest one (1.45). I just checked: * cpan_smoke_modules -pv 5.22.1 Dist::Zilla -> PASS * cpan_smoke_modules -pv 5.22.1 -pre ETHER/Moose-2.1700-TRIAL.tar.gz Dist::Zilla -> FAIL
Download (untitled) / with headers
text/plain 150b
The problem was related to (a) prototypes (b) relying on action at a distance. Stupid on my part to let that happen. I merged Karen's fix. -- rjbs


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.