Skip Menu |
 

This queue is for tickets about the PDF-API2 CPAN distribution.

Report information
The Basics
Id: 113514
Status: resolved
Priority: 0/
Queue: PDF-API2

People
Owner: Nobody in particular
Requestors: futuramedium [...] yandex.ru
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 2.027
Fixed in: 2.029



Subject: Typos in ExtGState.pm
Download (untitled) / with headers
text/plain 809b
In 2.027 (and probably all the way back), line #238 should set 'D' property instead of 'ML'. Line #258 should set 'RI' instead of 'FL'. Also, the module has no strictures enabled, and if we turn them on, then it dies in line #44, because of unknown '$self'. It's unclear what this method ('new_api') is supposed to do (and if it was ever used at all because of this bug), i.e. when we should use it -- both reading code and very cryptic pod. Plus, I had to look up what on Earth is the "Halftone Phase" - it's from the Display Postscript extensions, was described in Postscript Level2 Manual, briefly mentioned in PDF 1.2 and gone without a trace in later references. I think there's no need nor support for it anymore. Rather (it goes to wishlist :) ) the 'SMask' ExtGState parameter would be implemented.
Subject: [rt.cpan.org #113514]
Date: Sat, 2 Apr 2016 09:22:53 -0400
To: bug-PDF-API2 [...] rt.cpan.org
From: Phil M Perry <phil4597 [...] catskilltech.com>
Download (untitled) / with headers
text/plain 308b
Just a note that the {ML} value typo is a duplicate of bug 98552 (Extended Graphics State dash() method not working). I have not yet investigated whether it should be {D}. By all means go ahead and submit a patch. It appears that there was a lot of sloppy cut and paste in the early days of development.
Download (untitled) / with headers
text/plain 1.2k
On Sat Apr 02 07:37:37 2016, vadimr wrote: Show quoted text
> In 2.027 (and probably all the way back), line #238 should set 'D' > property instead of 'ML'. Line #258 should set 'RI' instead of 'FL'.
Fixed, thanks. This will be in the next release (2.029). The output of the dash() method was also incorrect, so I fixed that as well. Show quoted text
> Also, the module has no strictures enabled, and if we turn them on, > then it dies in line #44, because of unknown '$self'. It's unclear > what this method ('new_api') is supposed to do (and if it was ever > used at all because of this bug), i.e. when we should use it -- both > reading code and very cryptic pod.
You can ignore new_api. It's used internally, and will likely be removed soon. Show quoted text
> Plus, I had to look up what on Earth is the "Halftone Phase" - it's > from the Display Postscript extensions, was described in Postscript > Level2 Manual, briefly mentioned in PDF 1.2 and gone without a trace > in later references. I think there's no need nor support for it > anymore. Rather (it goes to wishlist :) ) the 'SMask' ExtGState > parameter would be implemented.
Feel free to send along a patch or a pull request that adds the SMask parameter. It doesn't look like it'll be too hard to add (you just need to check to see if the argument is a name or a dictionary, according to the spec).


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.