Skip Menu |
 

This queue is for tickets about the Catalyst-Runtime CPAN distribution.

Report information
The Basics
Id: 113388
Status: new
Priority: 0/
Queue: Catalyst-Runtime

People
Owner: Nobody in particular
Requestors: mauritzhansen [...] yapedi.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Warning when REMOTE_ADDR is undef
Date: Sun, 27 Mar 2016 23:21:51 +0200
To: bug-Catalyst-Runtime [...] rt.cpan.org
From: Mauritz Hansen <mauritzhansen [...] yapedi.com>
Download (untitled) / with headers
text/plain 658b
Hi folks, I log all warnings generated by my app, and my logfile is filled with the following warning: WARNING: Use of uninitialized value in string eq at /usr/local/share/perl/5.18.2/Catalyst.pm line 2960. REMOTE_ADDR may be empty, and this is not checked for. I have created the following patch (version 5.90103): @@ -3421,7 +3421,7 @@ condition => sub { my ($env) = @_; return if $app->config->{ignore_frontend_proxy}; - return $env->{REMOTE_ADDR} eq '127.0.0.1'; + return $env->{REMOTE_ADDR} && ($env->{REMOTE_ADDR} eq '127.0.0.1'); }, ); } Regards, Mauritz


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.