Skip Menu |
 

This queue is for tickets about the HTML-FormFu CPAN distribution.

Report information
The Basics
Id: 112582
Status: resolved
Priority: 0/
Queue: HTML-FormFu

People
Owner: Nobody in particular
Requestors: shixilun [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: test fails when run on leap day
Date: Mon, 29 Feb 2016 21:11:46 +0000
To: bug-HTML-FormFu [...] rt.cpan.org
From: Theron Stanford <shixilun [...] gmail.com>
Download (untitled) / with headers
text/plain 1.5k
Distribution name and version: HTML-FormFu-2.01 $ perl -v This is perl 5, version 18, subversion 2 (v5.18.2) built for darwin-thread-multi-2level (with 2 registered patches, see perl -V for more detail) $ uname -a Darwin Therons-MacBook-Pro.local 15.3.0 Darwin Kernel Version 15.3.0: Thu Dec 10 18:40:58 PST 2015; root:xnu-3248.30.4~1/RELEASE_X86_64 x86_64 Error message: t/aggregate.t .................. 110/402 # Failed test 'Error running (t-aggregate/elements/date_default_datetime_args.t): Couldn't parse 't-aggregate/elements/date_default_datetime_args.t': Invalid day of month (day = 29 - month = 2 - year = 2001) # at /Users/theronstanford/.cpan/build/HTML-FormFu-2.01-m0_G6L/blib/lib/HTML/FormFu/Element/Date.pm line 192. # ' # at /Library/Perl/5.18/Test/Aggregate/Nested.pm line 228. # Looks like you planned 3 tests but ran 1. # Looks like you failed 1 test of 1 run. # Failed test 'Tests for t-aggregate/elements/date_default_datetime_args.t' # at /Library/Perl/5.18/Test/Aggregate/Nested.pm line 229. t/aggregate.t .................. 257/402 # Looks like you failed 1 test of 402. t/aggregate.t .................. Dubious, test returned 1 (wstat 256, 0x100) It appears that the test is using the current day/month but a hardcoded year. Since the current day/month is 29 Feb and the hardcoded year is 2001, the date comes up as invalid. When I change the hardcoded year to 2004, the test passes. The hardcoded year appears in these two files: ./t-aggregate/elements/date_default_datetime_args.t ./t-aggregate/elements/date_default_datetime_args.yml
Download (untitled) / with headers
text/plain 185b
Fixed in git commit 3e485989aa8d8e452ab16b10557f6ac94dc55ca6 This will go into 2.03 https://github.com/fireartist/HTML-FormFu/commit/3e485989aa8d8e452ab16b10557f6ac94dc55ca6 Thank you


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.